Re: Add lasterrno setting for dir_existsfile()

2023-10-31 Thread Bruce Momjian
On Sat, Aug 13, 2022 at 02:46:24PM +0530, Bharath Rupireddy wrote: > On Sat, Aug 13, 2022 at 4:34 AM Bruce Momjian wrote: > > > > On Fri, Aug 12, 2022 at 06:22:01PM -0400, Bruce Momjian wrote: > > > On Mon, Jan 10, 2022 at 12:19:28AM +0800, Wei Sun wrote: > > > > Hi, > > > > > > > > Some time ago,

Re: Add lasterrno setting for dir_existsfile()

2022-08-13 Thread Bharath Rupireddy
On Sat, Aug 13, 2022 at 4:34 AM Bruce Momjian wrote: > > On Fri, Aug 12, 2022 at 06:22:01PM -0400, Bruce Momjian wrote: > > On Mon, Jan 10, 2022 at 12:19:28AM +0800, Wei Sun wrote: > > > Hi, > > > > > > Some time ago,the following patch clean up error handling in > > > pg_basebackup's > > > walme

Re: Add lasterrno setting for dir_existsfile()

2022-08-12 Thread Bruce Momjian
On Fri, Aug 12, 2022 at 06:22:01PM -0400, Bruce Momjian wrote: > On Mon, Jan 10, 2022 at 12:19:28AM +0800, Wei Sun wrote: > > Hi, > > > > Some time ago,the following patch clean up error handling in pg_basebackup's > > walmethods.c. > > https://github.com/postgres/postgres/commit/248c3a9 > > > >

Re: Add lasterrno setting for dir_existsfile()

2022-08-12 Thread Bruce Momjian
On Mon, Jan 10, 2022 at 12:19:28AM +0800, Wei Sun wrote: > Hi, > > Some time ago,the following patch clean up error handling in pg_basebackup's > walmethods.c. > https://github.com/postgres/postgres/commit/248c3a9 > > This patch keep the error state in the DirectoryMethodData struct, > in most fu

Add lasterrno setting for dir_existsfile()

2022-01-09 Thread Wei Sun
Hi, Some time ago,the following patch clean up error handling in pg_basebackup's walmethods.c. https://github.com/postgres/postgres/commit/248c3a9 This patch keep the error state in the DirectoryMethodData struct, in most functions, the lasterrno is set correctly, but in function dir_existsf