gt; we do for enum parameters in case where the user mistypes a wrong
>> > value. I'm not sure why the proposed patch needs to quote the usable
>> > values, though.
>>
>> I borrowed the description from pg_settings extra_desc. In my first patch,
>> I used the hint message line enum para
On Tue, Jul 11, 2023 at 10:24 AM Japin Li wrote:
>
>
> On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote:
> > On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
> > wrote:
> >>
> >> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
> >> >
> >> > On Sat, 08 Jul 2023 at 12:48, Michael Paquie
On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote:
> On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
> wrote:
>>
>> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>> >
>> > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
>> > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin L
On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
> >
> > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
> > >> + appendStringInfoString(&errhin
On Mon, Jul 10, 2023 at 02:07:09PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>> Sorry for the late reply! I'm not sure. How can I know whether it is
>> translatable?
Per the documentation:
https://www.postgresql.org/docs/devel/nls-programmer.html#
At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>
> On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
> >> + appendStringInfoString(&errhint, "\"stderr\"");
> >> +#ifdef HAVE_SYSLOG
> >> + a
On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
>> +appendStringInfoString(&errhint, "\"stderr\"");
>> +#ifdef HAVE_SYSLOG
>> +appendStringInfoString(&errhint, ", \"syslog\"");
>> +#endif
>>
On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
> + appendStringInfoString(&errhint, "\"stderr\"");
> +#ifdef HAVE_SYSLOG
> + appendStringInfoString(&errhint, ", \"syslog\"");
> +#endif
> +#ifdef WIN32
> + appendStringInfoString(
"");
> +#endif
> +#ifdef WIN32
> + appendStringInfo(&errhint, ", \"eventlog\"");
> +#endif
> + appendStringInfo(&errhint, ", \"csvlog\", and \"jsonlog\"");
>
> I think using appendStringI
On Fri, Jul 7, 2023 at 4:53 PM Japin Li wrote:
>
>
> On Fri, 07 Jul 2023 at 14:46, jian he wrote:
> > On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote:
> >>
> >>
> >> Hi, hackers
> >>
> >> When I try to change log_destination using ALTER SYSTEM with the wrong
> >> value,
> >> it complains of the "
review!
Yeah, the description of extra_desc is more accurate. Updated.
--
Regrads,
Japin Li.
>From 715f9811717c9d27f6b2f41db639b18e6ba58625 Mon Sep 17 00:00:00 2001
From: Japin Li
Date: Fri, 7 Jul 2023 15:48:53 +0800
Subject: [PATCH v2 1/1] Add hint message for check_log_destination
---
s
On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote:
>
>
> Hi, hackers
>
> When I try to change log_destination using ALTER SYSTEM with the wrong value,
> it complains of the "Unrecognized key word" without available values. This
> patch tries to add a hint message that provides available values for
>
Hi, hackers
When I try to change log_destination using ALTER SYSTEM with the wrong value,
it complains of the "Unrecognized key word" without available values. This
patch tries to add a hint message that provides available values for
log_destination. Any thoughts?
--
Regrads,
Japin Li.
>From
13 matches
Mail list logo
