Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Youki Shiraishi
Hello folks, On Fri, Sep 27, 2019 at 1:59 PM Amit Langote wrote: > > On Fri, Sep 27, 2019 at 12:52 PM Youki Shiraishi > wrote: > > On Fri, Sep 27, 2019 at 12:10 AM Amit Langote > > wrote: > > > On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi > > > wrote: > > > > On Thu, Sep 26, 2019 at 5:38

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Amit Langote
On Fri, Sep 27, 2019 at 12:52 PM Youki Shiraishi wrote: > On Fri, Sep 27, 2019 at 12:10 AM Amit Langote wrote: > > On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi > > wrote: > > > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote > > > wrote: > > > > + /* Bootstrap mode for initdb */ > > > > if

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Amit Langote
On Fri, Sep 27, 2019 at 1:03 PM Michael Paquier wrote: > > On Fri, Sep 27, 2019 at 12:29:08PM +0900, Youki Shiraishi wrote: > > I also vote to get rid of such ambiguous stuff. > > As you can see by grepping, "bootstrap-mode backend" (and something > > like that) is also called in the sources as: >

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Michael Paquier
On Fri, Sep 27, 2019 at 12:29:08PM +0900, Youki Shiraishi wrote: > I also vote to get rid of such ambiguous stuff. > As you can see by grepping, "bootstrap-mode backend" (and something > like that) is also called in the sources as: > > - bootstrap backend > - (basic) bootstrap process > - backend

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Youki Shiraishi
Hi Amit, On Fri, Sep 27, 2019 at 12:10 AM Amit Langote wrote: > > Hi Shiraishi-san, > > On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi > wrote: > > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote > > wrote: > > > On Thu, Sep 26, 2019 at 3:06 PM Youki Shiraishi > > > wrote: > > > > I have just

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Youki Shiraishi
Hello Tom, On Fri, Sep 27, 2019 at 12:23 AM Tom Lane wrote: > > Youki Shiraishi writes: > > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote > > wrote: > >> * The main entry point for auxiliary processes, such as the bgwriter, > >> - * walwriter, walreceiver, bootstrapper and the shared memory c

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Tom Lane
Youki Shiraishi writes: > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote wrote: >> * The main entry point for auxiliary processes, such as the bgwriter, >> - * walwriter, walreceiver, bootstrapper and the shared memory checker code. >> + * walwriter, walreceiver, postgres program in bootstrap mod

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Amit Langote
Hi Shiraishi-san, On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi wrote: > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote wrote: > > On Thu, Sep 26, 2019 at 3:06 PM Youki Shiraishi > > wrote: > > > I have just started to read the PostgreSQL code and found a lack of > > > comments for a postgres

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Youki Shiraishi
Hello Amit, On Thu, Sep 26, 2019 at 5:38 PM Amit Langote wrote: > > Hi Shiraishi-san, > > On Thu, Sep 26, 2019 at 3:06 PM Youki Shiraishi > wrote: > > > > Hi, > > > > I have just started to read the PostgreSQL code and found a lack of > > comments for a postgres backend program in bootstrap mo

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Amit Langote
Hi Shiraishi-san, On Thu, Sep 26, 2019 at 3:06 PM Youki Shiraishi wrote: > > Hi, > > I have just started to read the PostgreSQL code and found a lack of comments > for a postgres backend program in bootstrap mode. > When I saw the --boot option implemented in src/backend/main/main.c at first >

Add comments for a postgres program in bootstrap mode

2019-09-25 Thread Youki Shiraishi
Hi, I have just started to read the PostgreSQL code and found a lack of comments for a postgres backend program in bootstrap mode. When I saw the --boot option implemented in src/backend/main/main.c at first time, I did not understand why the --boot option is not documented and what it is used for