On Thu, Sep 05, 2024 at 12:41:09PM +0900, Michael Paquier wrote:
> Not sure which one is better than the other, TBH. Either way, we
> still have a full release cycle to finalize that, and I am OK to
> switch the name to something else if there are more folks in favor of
> one, the other or even so
On Wed, Sep 04, 2024 at 06:42:33PM +0900, Kyotaro Horiguchi wrote:
> More accurately, I believe this applies when the sentence follows a
> verb-object structure. In this case, the function’s meaning is “pgstat
> initialization on backend,” which seems somewhat different from the
> policy you mentio
At Wed, 4 Sep 2024 15:04:09 +0900, Michael Paquier wrote
in
> On Wed, Sep 04, 2024 at 02:15:43PM +0900, Kyotaro Horiguchi wrote:
> > The name "init_backend" makes it sound like the function initializes
> > the backend. backend_init might be a better choice, but I'm not sure.
>
> We (kind of) te
On Wed, Sep 04, 2024 at 02:15:43PM +0900, Kyotaro Horiguchi wrote:
> The name "init_backend" makes it sound like the function initializes
> the backend. backend_init might be a better choice, but I'm not sure.
We (kind of) tend to prefer $verb_$thing-or-action_cb for the name of
the callbacks, whi
At Tue, 3 Sep 2024 05:00:54 +, Bertrand Drouvot
wrote in
> Hi,
>
> On Tue, Sep 03, 2024 at 10:52:20AM +0900, Michael Paquier wrote:
> > Hi all,
> >
> > Currently, the backend-level initialization of pgstats happens in
> > pgstat_initialize(), where we are using a shortcut for the WAL stats
On Tue, Sep 03, 2024 at 05:00:54AM +, Bertrand Drouvot wrote:
> Should we add a few words about this new callback (and the others in
> PgStat_KindInfo while at it) in the "Custom Cumulative Statistics" section of
> xfunc.sgml?
Not sure if it is worth having. This adds extra maintenance and
th
Hi,
On Tue, Sep 03, 2024 at 10:52:20AM +0900, Michael Paquier wrote:
> Hi all,
>
> Currently, the backend-level initialization of pgstats happens in
> pgstat_initialize(), where we are using a shortcut for the WAL stats,
> with pgstat_init_wal().
>
> I'd like to propose to add a callback for tha
Hi all,
Currently, the backend-level initialization of pgstats happens in
pgstat_initialize(), where we are using a shortcut for the WAL stats,
with pgstat_init_wal().
I'd like to propose to add a callback for that, so as in-core or
custom pgstats kinds can assign custom actions when initializing
