Re: Add a test for "cannot truncate foreign table"

2022-07-19 Thread Yugo NAGATA
On Wed, 20 Jul 2022 09:38:17 +0900 Fujii Masao wrote: > > > On 2022/07/15 16:52, Fujii Masao wrote: > > > > > > On 2022/07/08 17:03, Etsuro Fujita wrote: > >> Rather than doing so, I'd vote for adding a test case to file_fdw, as > >> proposed in the patch, because that would be much simpler a

Re: Add a test for "cannot truncate foreign table"

2022-07-19 Thread Fujii Masao
On 2022/07/15 16:52, Fujii Masao wrote: On 2022/07/08 17:03, Etsuro Fujita wrote: Rather than doing so, I'd vote for adding a test case to file_fdw, as proposed in the patch, because that would be much simpler and much less expensive. So ISTM that most agreed to push Nagata-san's patch ad

Re: Add a test for "cannot truncate foreign table"

2022-07-15 Thread Fujii Masao
On 2022/07/08 17:03, Etsuro Fujita wrote: Rather than doing so, I'd vote for adding a test case to file_fdw, as proposed in the patch, because that would be much simpler and much less expensive. So ISTM that most agreed to push Nagata-san's patch adding the test for TRUNCATE on foreign tabl

Re: Add a test for "cannot truncate foreign table"

2022-07-08 Thread Etsuro Fujita
On Fri, Jul 8, 2022 at 11:07 AM Yugo NAGATA wrote: > On Fri, 08 Jul 2022 09:44:10 +0900 (JST) > Kyotaro Horiguchi wrote: > > At Fri, 8 Jul 2022 01:06:18 +0900, Fujii Masao > > wrote in > > > On 2022/07/08 0:33, Tom Lane wrote: > > > >> On 2022/06/30 10:48, Yugo NAGATA wrote: > > > >>> When a f

Re: Add a test for "cannot truncate foreign table"

2022-07-07 Thread Yugo NAGATA
On Fri, 08 Jul 2022 09:44:10 +0900 (JST) Kyotaro Horiguchi wrote: > At Fri, 8 Jul 2022 01:06:18 +0900, Fujii Masao > wrote in > > > > > > On 2022/07/08 0:33, Tom Lane wrote: > > > Fujii Masao writes: > > >> On 2022/06/30 10:48, Yugo NAGATA wrote: > > >>> When a foreign table has handler but

Re: Add a test for "cannot truncate foreign table"

2022-07-07 Thread Kyotaro Horiguchi
At Fri, 8 Jul 2022 01:06:18 +0900, Fujii Masao wrote in > > > On 2022/07/08 0:33, Tom Lane wrote: > > Fujii Masao writes: > >> On 2022/06/30 10:48, Yugo NAGATA wrote: > >>> When a foreign table has handler but doesn't support TRUNCATE, > >>> an error "cannot truncate foreign table xxx" occurs

Re: Add a test for "cannot truncate foreign table"

2022-07-07 Thread Fujii Masao
On 2022/07/08 0:33, Tom Lane wrote: Fujii Masao writes: On 2022/06/30 10:48, Yugo NAGATA wrote: When a foreign table has handler but doesn't support TRUNCATE, an error "cannot truncate foreign table xxx" occurs. So, what about adding a test this message output? We can add this test for file

Re: Add a test for "cannot truncate foreign table"

2022-07-07 Thread Tom Lane
Fujii Masao writes: > On 2022/06/30 10:48, Yugo NAGATA wrote: >> When a foreign table has handler but doesn't support TRUNCATE, >> an error "cannot truncate foreign table xxx" occurs. So, what >> about adding a test this message output? We can add this test >> for file_fdw because it is one of the

Re: Add a test for "cannot truncate foreign table"

2022-07-07 Thread Fujii Masao
On 2022/06/30 10:48, Yugo NAGATA wrote: Hello, During checking regression tests of TRUNCATE on foreign tables for other patch [1], I found that there is no test for foreign tables that don't support TRUNCATE. When a foreign table has handler but doesn't support TRUNCATE, an error "cannot tru

Add a test for "cannot truncate foreign table"

2022-06-29 Thread Yugo NAGATA
Hello, During checking regression tests of TRUNCATE on foreign tables for other patch [1], I found that there is no test for foreign tables that don't support TRUNCATE. When a foreign table has handler but doesn't support TRUNCATE, an error "cannot truncate foreign table xxx" occurs. So, what ab