Re: Add a semicolon to query related to search_path

2018-08-30 Thread Tatsuro Yamada
On 2018/08/31 2:28, Peter Eisentraut wrote: On 17/08/2018 05:32, Tatsuro Yamada wrote: Hi Robert, On 2018/08/17 4:32, Robert Haas wrote: On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada wrote: As you can see, queries with and without a semicolon are mixed, it is hard to understand the end of

Re: Add a semicolon to query related to search_path

2018-08-30 Thread Peter Eisentraut
On 17/08/2018 05:32, Tatsuro Yamada wrote: > Hi Robert, > > On 2018/08/17 4:32, Robert Haas wrote: >> On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada >> wrote: >>> As you can see, queries with and without a semicolon are mixed, it is hard >>> to understand the end of each query. This is not beaut

Re: Add a semicolon to query related to search_path

2018-08-16 Thread Tatsuro Yamada
Hi Robert, On 2018/08/17 4:32, Robert Haas wrote: On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada wrote: As you can see, queries with and without a semicolon are mixed, it is hard to understand the end of each query. This is not beautiful and user-friendly, do not you think so? I agree with

Re: Add a semicolon to query related to search_path

2018-08-16 Thread Robert Haas
On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada wrote: > As you can see, queries with and without a semicolon are mixed, it is hard > to understand the end of each query. This is not beautiful and > user-friendly, > do not you think so? I agree with you. -- Robert Haas EnterpriseDB: http://www.

Re: Add a semicolon to query related to search_path

2018-08-15 Thread Tatsuro Yamada
Hi Tom, On 2018/08/15 22:27, Tom Lane wrote: Tatsuro Yamada writes: Attached patch gives the following query a semicolon for readability. s/SELECT pg_catalog.set_config ('search_path', '', false)/ SELECT pg_catalog.set_config ('search_path', '', false);/ I'm not exactly convinced t

Re: Add a semicolon to query related to search_path

2018-08-15 Thread Tom Lane
Tatsuro Yamada writes: > Attached patch gives the following query a semicolon for readability. >s/SELECT pg_catalog.set_config ('search_path', '', false)/ > SELECT pg_catalog.set_config ('search_path', '', false);/ I'm not exactly convinced that this is worth doing. There are an awful l

Add a semicolon to query related to search_path

2018-08-14 Thread Tatsuro Yamada
Hi, I found some improvements in Client Applications in /src/bin/scripts when I resumed development of progress monitor for cluster command. Attached patch gives the following query a semicolon for readability. s/SELECT pg_catalog.set_config ('search_path', '', false)/ SELECT pg_catalog.s