Re: Add TOAST support for more system tables

2023-07-18 Thread Sofia Kopikova
On Mon, Jul 17, 2023 at 06:31:04PM -0400, Tom Lane wrote: Sofia Kopikova writes: This patch adds TOAST support for system tables pg_class, pg_attribute and pg_largeobject_metadata, as they include ACL columns, which may be potentially large in size. We have been around on this topic before, c

Re: Add TOAST support for more system tables

2023-07-17 Thread Michael Paquier
On Mon, Jul 17, 2023 at 06:31:04PM -0400, Tom Lane wrote: > Sofia Kopikova writes: > > This patch adds TOAST support for system tables pg_class, > > pg_attribute and pg_largeobject_metadata, as they include ACL columns, > > which may be potentially large in size. > > We have been around on this t

Re: Add TOAST support for more system tables

2023-07-17 Thread David Rowley
On Tue, 18 Jul 2023 at 10:31, Tom Lane wrote: > I wonder whether we'd be better off shoving the ACL data out of > these catalogs and putting it somewhere else (compare pg_attrdef). relpartbound is another column that could cause a pg_class row to grow too large. I did have a patch [1] to move th

Re: Add TOAST support for more system tables

2023-07-17 Thread Tom Lane
Sofia Kopikova writes: > This patch adds TOAST support for system tables pg_class, > pg_attribute and pg_largeobject_metadata, as they include ACL columns, > which may be potentially large in size. We have been around on this topic before, cf discussion leading up to commit 96cdeae07. Allowing t

Add TOAST support for more system tables

2023-07-17 Thread Sofia Kopikova
Hi, hackers! I've tried sending this patch to community before, let me try it second time. Patch is revised and improved compared to previous version. This patch adds TOAST support for system tables pg_class, pg_attribute and pg_largeobject_metadata, as they include ACL columns, which may be pot