On Mon, Jan 22, 2024 at 8:48 PM Andrew Dunstan wrote:
>
>
> On 2024-01-21 Su 22:19, Peter Smith wrote:
> > 2024-01 Commitfest.
> >
> > Hi, This patch has a CF status of "Needs Review" [1], but it seems
> > like there was some CFbot test failure last time it was run [2].
> > Please have a look and
On 2024-01-21 Su 22:19, Peter Smith wrote:
2024-01 Commitfest.
Hi, This patch has a CF status of "Needs Review" [1], but it seems
like there was some CFbot test failure last time it was run [2].
Please have a look and post an updated version if necessary.
I don't think there's a consensus t
2024-01 Commitfest.
Hi, This patch has a CF status of "Needs Review" [1], but it seems
like there was some CFbot test failure last time it was run [2].
Please have a look and post an updated version if necessary.
==
[1] https://commitfest.postgresql.org/46/4691/
[2] https://cirrus-ci.com/task
On Wed Jan 10, 2024 at 1:58 AM CST, Tom Lane wrote:
Bharath Rupireddy writes:
> IMO, running the
> pgindent in at least one of the CI systems if not all (either as part
> task SyanityCheck or task Linux - Debian Bullseye - Autoconf) help
> catches things early on in CF bot runs itself. This save
Bharath Rupireddy writes:
> On Wed, Jan 10, 2024 at 12:54 PM Tom Lane wrote:
>> Yeah. I'm not quite sure what's a good way to make this work, but
>> it seems like having "make check-world" always invoke it would not
>> be desirable. Making that conditional on an environment variable
>> setting
On Wed, Jan 10, 2024 at 12:54 PM Tom Lane wrote:
>
> Michael Paquier writes:
> > On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote:
> >> So that leads to the conclusion that I wouldn't want an automatic
> >> pgindent check to happen during "make all" or "make check", because
> >> I want th
Michael Paquier writes:
> On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote:
>> So that leads to the conclusion that I wouldn't want an automatic
>> pgindent check to happen during "make all" or "make check", because
>> I want those things to succeed before I consider pgindent'ing.
>> Maybe
On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote:
> John Naylor writes:
>> Off the top of my head, I like to use '//' comments as quick notes to
>> myself that stand out from normal code comments, and I'm in the habit
>> of putting debug print statements flush against the left margin so
>>
John Naylor writes:
> Off the top of my head, I like to use '//' comments as quick notes to
> myself that stand out from normal code comments, and I'm in the habit
> of putting debug print statements flush against the left margin so
> they're really obvious. Both of these would be wiped out by pgi
On Wed, Jan 10, 2024 at 2:20 AM Tristan Partin wrote:
>
> On Tue Jan 9, 2024 at 3:00 AM CST, John Naylor wrote:
> > I don't indent during most of development, and don't intend to start.
>
> Could you expand on why you don't? I could understand as you're writing,
> but I would think formatting on s
Robert Haas writes:
> I think we need to do that, too, but the question is how. The best
> suggestion I've heard so far was to make it part of the build, or part
> of the test suite, so that if you don't do it, some part of what you
> were going to do anyway actually fails. That avoids making it a
On Tue, Jan 9, 2024 at 4:42 PM Daniel Gustafsson wrote:
> > On 9 Jan 2024, at 22:20, Tom Lane wrote:
> > In short, I don't think that putting this into CI is the answer.
> > Putting it into committers' standard workflow is a better idea,
> > if we can get all the committers on board with that.
>
On 1/9/24 3:20 PM, Tom Lane wrote:
In short, I don't think that putting this into CI is the answer.
Putting it into committers' standard workflow is a better idea,
if we can get all the committers on board with that.
FWIW, that's the approach that go takes - not only for committing to go
itsel
> On 9 Jan 2024, at 22:20, Tom Lane wrote:
> In short, I don't think that putting this into CI is the answer.
> Putting it into committers' standard workflow is a better idea,
> if we can get all the committers on board with that.
+many
--
Daniel Gustafsson
Robert Haas writes:
> On Tue, Jan 9, 2024 at 2:20 PM Tristan Partin wrote:
>>> I don't indent during most of development, and don't intend to start.
>> Could you expand on why you don't? I could understand as you're writing,
>> but I would think formatting on save, might be useful.
> John might
On Tue Jan 9, 2024 at 2:49 PM CST, Robert Haas wrote:
On Tue, Jan 9, 2024 at 2:20 PM Tristan Partin wrote:
> > I don't indent during most of development, and don't intend to start.
>
> Could you expand on why you don't? I could understand as you're writing,
> but I would think formatting on save
On Tue, Jan 9, 2024 at 2:20 PM Tristan Partin wrote:
> > I don't indent during most of development, and don't intend to start.
>
> Could you expand on why you don't? I could understand as you're writing,
> but I would think formatting on save, might be useful.
John might have his own answer to th
On Tue Jan 9, 2024 at 3:00 AM CST, John Naylor wrote:
On Mon, Oct 30, 2023 at 2:21 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> How about adding code indent checks (like what BF member koel has) to
> the SanityCheck CI task? This helps catch indentation problems way
> before things are committed so t
>From the previous thread on this issue. I think the following proposal
seemed like it had the most buy-in from committers. But so far nobody
implemented it:
On Wed, 18 Oct 2023 at 16:07, Robert Haas wrote:
>
> On Wed, Oct 18, 2023 at 3:21 AM Peter Eisentraut wrote:
> > On 18.10.23 06:40, David
On Mon, Oct 30, 2023 at 2:21 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> How about adding code indent checks (like what BF member koel has) to
> the SanityCheck CI task? This helps catch indentation problems way
> before things are committed so that developers can find them out in
> their respective C
Hi,
You may want to check out the WIP patch [1] about adding meson targets
to run pgindent by Andres.
[1]
https://www.postgresql.org/message-id/20231019044907.ph6dw637loqg3lqk%40awork3.anarazel.de
--
Regards,
Nazir Bilal Yavuz
Microsoft
On Mon, Oct 30, 2023 at 12:50 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> How about adding code indent checks (like what BF member koel has) to
> the SanityCheck CI task? This helps catch indentation problems way
> before things are committed so that developers can find them out in
> their respective
Hi,
How about adding code indent checks (like what BF member koel has) to
the SanityCheck CI task? This helps catch indentation problems way
before things are committed so that developers can find them out in
their respective CI runs and lets developers learn the postgres code
indentation stuff. I
23 matches
Mail list logo
