Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Daniel Gustafsson
> On 30 Sep 2024, at 17:43, Tom Lane wrote: > > Nathan Bossart writes: >> On Mon, Sep 30, 2024 at 04:13:55PM +0200, Daniel Gustafsson wrote: >>> I'm not a native speaker so I'm not sure which is right, but grepping for >>> other >>> lists of items shows that the last "and" item is often precede

Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Tom Lane
Nathan Bossart writes: > On Mon, Sep 30, 2024 at 04:13:55PM +0200, Daniel Gustafsson wrote: >> I'm not a native speaker so I'm not sure which is right, but grepping for >> other >> lists of items shows that the last "and" item is often preceded by a comma so >> I'll do that. > I'm not aware of a

Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Nathan Bossart
On Mon, Sep 30, 2024 at 04:13:55PM +0200, Daniel Gustafsson wrote: >> On 30 Sep 2024, at 12:38, Yugo Nagata wrote: >> >> Should we put a comma between REINDEX and "and" as following? >> >> "... MATERIALIZED VIEW, REINDEX, and LOCK TABLE on all relations." > > I'm not a native speaker so I'm not

Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Daniel Gustafsson
> On 30 Sep 2024, at 12:38, Yugo Nagata wrote: > > On Mon, 30 Sep 2024 11:40:29 +0200 > Daniel Gustafsson wrote: > >> - * MATERIALIZED VIEW, and REINDEX on all relations. >> + * MATERIALIZED VIEW, REINDEX and LOCK TABLE on all relations. > > Should we put a comma between REINDEX and "and" as f

Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Yugo Nagata
On Mon, 30 Sep 2024 11:40:29 +0200 Daniel Gustafsson wrote: > - * MATERIALIZED VIEW, and REINDEX on all relations. > + * MATERIALIZED VIEW, REINDEX and LOCK TABLE on all relations. Should we put a comma between REINDEX and "and" as following? "... MATERIALIZED VIEW, REINDEX, and LOCK

Re: ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread Daniel Gustafsson
> On 30 Sep 2024, at 10:29, btsugieyuusuke > wrote: > > Hi hackers, > I found a flaw in the ACL_MAINTAIN comment. > > Commands such as VACUUM are listed as commands that are allowed to be > executed by the MAINTAIN privilege. > However, LOCK TABLE is missing from the comment. > >> /* >> * Che

ACL_MAINTAIN, Lack of comment content

2024-09-30 Thread btsugieyuusuke
Hi hackers, I found a flaw in the ACL_MAINTAIN comment. Commands such as VACUUM are listed as commands that are allowed to be executed by the MAINTAIN privilege. However, LOCK TABLE is missing from the comment. /* * Check if ACL_MAINTAIN is being checked and, if so, and not already