On Thu, May 16, 2024 at 8:42 PM Robert Haas wrote:
> You don't need to wait for the next CommitFest to fix a comment (or a
> bug). And, indeed, it's better if you do this before we branch.
Patch pushed and the CF entry closed. Thank you for the suggestion.
Thanks
Richard
On Thu, May 16, 2024 at 5:58 AM Richard Guo wrote:
> Thank you for the suggestion. Yeah, this is a good candidate for my
> first commit. :-) I will aim to do it during the next commitfest.
You don't need to wait for the next CommitFest to fix a comment (or a
bug). And, indeed, it's better if yo
On Wed, May 15, 2024 at 1:07 AM Robert Haas wrote:
> On Mon, Dec 4, 2023 at 3:42 AM Richard Guo wrote:
> > Then here is a trivial patch to adjust the comment, which should get
> > reverted along with 867be9c07.
>
> Richard, since you're a committer now, maybe you'd like to commit
> this. I don't
On Mon, Dec 4, 2023 at 3:42 AM Richard Guo wrote:
> Then here is a trivial patch to adjust the comment, which should get
> reverted along with 867be9c07.
Richard, since you're a committer now, maybe you'd like to commit
this. I don't really understand the portion of your commit message
inside the
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Comment is updated correctly.
On Sat, Dec 2, 2023 at 2:27 AM Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2023-Dec-01, Richard Guo wrote:
> >> However, this cross-check will also be performed in non-debug builds
> >> ever since commit 867be9c07, which converts this check from Asserts to
> >> test-and-elog. The commit mes
Alvaro Herrera writes:
> On 2023-Dec-01, Richard Guo wrote:
>> However, this cross-check will also be performed in non-debug builds
>> ever since commit 867be9c07, which converts this check from Asserts to
>> test-and-elog. The commit message there also says:
>> Committed separately with the idea
On 2023-Dec-01, Richard Guo wrote:
> However, this cross-check will also be performed in non-debug builds
> ever since commit 867be9c07, which converts this check from Asserts to
> test-and-elog. The commit message there also says:
>
> Committed separately with the idea that eventually we'll
The comment of search_indexed_tlist_for_var says:
* In debugging builds, we cross-check the varnullingrels of the subplan
* output Var based on nrm_match.
However, this cross-check will also be performed in non-debug builds
ever since commit 867be9c07, which converts this check from Asserts to
