Re: A slightly misleading comment in GetNewObjectId()

2018-08-16 Thread Robert Haas
On Thu, Aug 16, 2018 at 12:47 AM, Tom Lane wrote: > Thomas Munro writes: >> That makes it sound like a mere optimisation, but since commit >> 8e18d04d4da user-created objects are not allowed to have OIDs below >> that threshold. So I propose the attached tweak. > > +1 Looks good to me, too. --

Re: A slightly misleading comment in GetNewObjectId()

2018-08-15 Thread Tom Lane
Thomas Munro writes: > That makes it sound like a mere optimisation, but since commit > 8e18d04d4da user-created objects are not allowed to have OIDs below > that threshold. So I propose the attached tweak. +1 regards, tom lane

A slightly misleading comment in GetNewObjectId()

2018-08-15 Thread Thomas Munro
Hi hackers, While contemplating plans to use new kinds of OIDs in buffer tags, I noticed $SUBJECT. It says: * Check for wraparound of the OID counter. We *must* not return 0 * (InvalidOid); and as long as we have to check that, it seems a good * idea to skip over everything below FirstNormal