Re: A modest proposal: let's add PID to assertion failure messages

2020-10-06 Thread Andres Freund
On 2020-10-05 10:20:01 +1300, Thomas Munro wrote: > On Mon, Oct 5, 2020 at 10:08 AM Tom Lane wrote: > > In these days when we run almost all test cases in parallel, it's > > frequently not that easy to tie a "TRAP: ..." message in the log > > to nearby log messages. (The postmaster's subsequent c

Re: A modest proposal: let's add PID to assertion failure messages

2020-10-04 Thread Tom Lane
Michael Paquier writes: > +1. (log_line_prefix includes %p in its default configuration for the > TAP tests). Right, but of course you don't get log_line_prefix on Assert messages. regards, tom lane

Re: A modest proposal: let's add PID to assertion failure messages

2020-10-04 Thread Michael Paquier
On Mon, Oct 05, 2020 at 10:20:01AM +1300, Thomas Munro wrote: > On Mon, Oct 5, 2020 at 10:08 AM Tom Lane wrote: >> In these days when we run almost all test cases in parallel, it's >> frequently not that easy to tie a "TRAP: ..." message in the log >> to nearby log messages. (The postmaster's sub

Re: A modest proposal: let's add PID to assertion failure messages

2020-10-04 Thread Thomas Munro
On Mon, Oct 5, 2020 at 10:08 AM Tom Lane wrote: > In these days when we run almost all test cases in parallel, it's > frequently not that easy to tie a "TRAP: ..." message in the log > to nearby log messages. (The postmaster's subsequent complaint > often helps, but it could be some distance away

A modest proposal: let's add PID to assertion failure messages

2020-10-04 Thread Tom Lane
In these days when we run almost all test cases in parallel, it's frequently not that easy to tie a "TRAP: ..." message in the log to nearby log messages. (The postmaster's subsequent complaint often helps, but it could be some distance away in the log; and good luck untangling things if more than