Re: Andres Freund
> > I'd be good with tweaking this test case as you suggest, and maybe
> > revisiting the topic later.
>
> Pushed the change of the test. Christoph, just to make sure, can you confirm
> that this fixes the test instability for you?
Unfortunately I could not reproduce the problem
Hi,
On 2022-05-20 01:25:10 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-05-20 00:22:14 -0400, Tom Lane wrote:
> >> There's some fallout in the expected-file, of course, but this
> >> does seem to fix it (20 consecutive successful runs now at
> >> 100/2). Don't see why though ...
>
I wrote:
> Andres Freund writes:
>> I think what might be happening is that the transactional stats updates get
>> reported by s2 *before* the non-transactional stats updates come in from
>> s1. I.e. the pgstat_report_stat() at the end of s2_commit_prepared_a does a
>> report, because the machine
Andres Freund writes:
> On 2022-05-20 00:22:14 -0400, Tom Lane wrote:
>> There's some fallout in the expected-file, of course, but this
>> does seem to fix it (20 consecutive successful runs now at
>> 100/2). Don't see why though ...
> I think what might be happening is that the transactional st
Hi,
On 2022-05-20 00:22:14 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Hm. Does the instability vanish if you switch s2_commit_prepared_a and
> > s1_ff?
>
> Like this?
Yea.
> diff --git a/src/test/isolation/specs/stats.spec
> b/src/test/isolation/specs/stats.spec
> index be4ae1f4ff..
Andres Freund writes:
> Hm. Does the instability vanish if you switch s2_commit_prepared_a and s1_ff?
Like this?
diff --git a/src/test/isolation/specs/stats.spec
b/src/test/isolation/specs/stats.spec
index be4ae1f4ff..70be29b207 100644
--- a/src/test/isolation/specs/stats.spec
+++ b/src/test/is
At Thu, 19 May 2022 22:58:14 -0400, Tom Lane wrote in
> Kyotaro Horiguchi writes:
> Notice that these markers can only delay reporting of the completion
> of a step, not the launch of a step. The isolationtester will launch
> the next step in a permutation as soon as (A) all prior s
Hi,
On 2022-05-19 22:58:14 -0400, Tom Lane wrote:
> What I am wondering about at this point is whether the effects of
> pg_stat_force_next_flush() could somehow be delayed until after we
> have told the client the command is complete.
It shouldn't - it just forces pg_stat_report_stat() to flush (
Andres Freund writes:
> On 2022-05-19 21:42:31 -0400, Tom Lane wrote:
>> Even more interesting, the repeatability varies with the settings
>> of max_connections and max_prepared_transactions.
> That is indeed quite odd.
>> At low values (resp. 20 and 0) I've not been able to make it happen at al
Hi,
On 2022-05-19 21:42:31 -0400, Tom Lane wrote:
> >
> > seq_scan|seq_tup_read|n_tup_ins|n_tup_upd|n_tup_del|n_live_tup|n_dead_tup|vacuum_count
> >
> > ++-+-+-+--+--+
> > - 3| 9|5|1|
Kyotaro Horiguchi writes:
> At Fri, 20 May 2022 11:02:21 +0900 (JST), Kyotaro Horiguchi
> wrote in
>> Doesn't the step s1_table_stats needs a blocking condition (s2_ff)?
> s/needs/need/;
> If I removed the step s2_ff, I see the same difference. So I think it
> is that. Some other permutations
At Fri, 20 May 2022 11:02:21 +0900 (JST), Kyotaro Horiguchi
wrote in
> Doesn't the step s1_table_stats needs a blocking condition (s2_ff)?
s/needs/need/;
If I removed the step s2_ff, I see the same difference. So I think it
is that. Some other permutations seem to need the same.
regards.
--
At Thu, 19 May 2022 21:42:31 -0400, Tom Lane wrote in
> Christoph Berg writes:
> > Debian unstable mips (the old 32-bit one):
>
> > --- /<>/src/test/isolation/expected/stats.out 2022-05-16
> > 21:10:42.0 +
> > +++ /<>/build/src/test/isolation/output_iso/results/stats.out
> > 202
Christoph Berg writes:
> Debian unstable mips (the old 32-bit one):
> --- /<>/src/test/isolation/expected/stats.out2022-05-16
> 21:10:42.0 +
> +++ /<>/build/src/test/isolation/output_iso/results/stats.out
> 2022-05-18 23:26:56.573000536 +
> @@ -2854,7 +2854,7 @@
>
> se
Debian unstable mips (the old 32-bit one):
test vacuum-conflict ... ok 2170 ms
test vacuum-skip-locked ... ok 2445 ms
test stats... FAILED38898 ms
test horizons ... ok 4543 ms
test predicate-hash
15 matches
Mail list logo
