Re: 15beta1 tab completion of extension versions

2022-07-03 Thread Tom Lane
Noah Misch writes: > On Sun, Jul 03, 2022 at 02:00:59PM -0400, Tom Lane wrote: >> This will require one extra when what you want is to update to >> a specific version, but I doubt that that's going to bother anyone >> very much. I don't want to try to resurrect the v14 behavior exactly >> becaus

Re: 15beta1 tab completion of extension versions

2022-07-03 Thread Noah Misch
On Sun, Jul 03, 2022 at 02:00:59PM -0400, Tom Lane wrote: > I wrote: > > Noah Misch writes: > >> "ALTER EXTENSION hstore UPDATE;" is a valid command (updates to the > >> control file default version). Hence, I think the v14 behavior was better. > > > Hmm ... good point, let me think about that.

Re: 15beta1 tab completion of extension versions

2022-07-03 Thread Tom Lane
I wrote: > Noah Misch writes: >> "ALTER EXTENSION hstore UPDATE;" is a valid command (updates to the >> control file default version). Hence, I think the v14 behavior was better. > Hmm ... good point, let me think about that. After consideration, my preferred solution is just this: diff --git

Re: 15beta1 tab completion of extension versions

2022-07-03 Thread Tom Lane
Noah Misch writes: > I think it makes sense to send UPDATE TO as a single completion in places > where no valid command can have the UPDATE without the TO. CREATE RULE foo AS > ON UPDATE TO is a candidate, though CREATE RULE completion doesn't do that > today. "ALTER EXTENSION hstore UPDATE;" is

Re: 15beta1 tab completion of extension versions

2022-07-03 Thread Noah Misch
On Sun, Jun 19, 2022 at 12:56:13AM -0400, Tom Lane wrote: > Actually ... after further thought it seems like maybe we should > make this more like other cases rather than less so. ISTM that much > of the issue here is somebody's decision that "TO version" should be > offered as a completion of "UP

Re: 15beta1 tab completion of extension versions

2022-06-18 Thread Tom Lane
I wrote: > Jeff Janes writes: >> Putting pg_catalog.quote_ident back >> into Query_for_list_of_available_extension_versions* fixes it, but might >> not be the best way to fix it. > Yeah, that seems like the appropriate fix. Done, thanks for the report! Actually ... after further thought it seem

Re: 15beta1 tab completion of extension versions

2022-06-18 Thread Tom Lane
Jeff Janes writes: > Extension version strings need to be quoted. Either double or single > quotes will work. In released psql clients, tab completion offers double > quoted suggestions: > But commit 02b8048ba5 broke that, it now offers unquoted version strings > which if used as offered then le

15beta1 tab completion of extension versions

2022-06-18 Thread Jeff Janes
Extension version strings need to be quoted. Either double or single quotes will work. In released psql clients, tab completion offers double quoted suggestions: alter extension pg_trgm update TO "1.3" "1.4" "1.5" "1.6" But commit 02b8048ba5 broke that, it now offers unquoted version string