On Tue, Apr 14, 2020 at 10:11:56AM +0900, Michael Paquier wrote:
> Indeed. Any code path of pg_dump calling buildACLQueries() clears up
> things, and I think that it is a better practice to clean up properly
> PQExpBuffer stuff even if there is always the argument that pg_dump
> is a tool running
On Mon, Apr 13, 2020 at 04:51:06PM +0900, Masahiko Sawada wrote:
> On Tue, 7 Apr 2020 at 11:42, Zhang, Jie wrote:
>> In getDefaultACLs function, some PQExpBuffer are not destroy
>
> Yes, it looks like an oversight. It's related to the commit
> e2090d9d20d809 which is back-patched to 9.6.
>
> The
On Tue, 7 Apr 2020 at 11:42, Zhang, Jie wrote:
>
> Hi al
>
> In getDefaultACLs function, some PQExpBuffer are not destroy
>
Yes, it looks like an oversight. It's related to the commit
e2090d9d20d809 which is back-patched to 9.6.
The patch looks good to me.
Regards,
--
Masahiko Sawada
Hi al
In getDefaultACLs function, some PQExpBuffer are not destroy
File: src/bin/pg_dump/pg_dump.c
DefaultACLInfo *
getDefaultACLs(Archive *fout, int *numDefaultACLs)
{
..
if (fout->remoteVersion >= 90600)
{
PQExpBuffer acl_subquery = createPQExpBuffer();
