Re: [patch] ENUM errdetail should mention bytes, not chars

2020-10-27 Thread Ian Lawrence Barwick
2020年10月27日(火) 20:00 Peter Eisentraut : > > On 2020-10-19 06:34, Julien Rouhaud wrote: > >> ERROR: invalid enum label "ああ" > >> DETAIL: Labels must be 63 characters or less. > >> > >> Attached trivial patch changes the message to: > >> > >> DETAIL: Labels must

Re: [patch] ENUM errdetail should mention bytes, not chars

2020-10-27 Thread Peter Eisentraut
On 2020-10-19 06:34, Julien Rouhaud wrote: ERROR: invalid enum label "ああ" DETAIL: Labels must be 63 characters or less. Attached trivial patch changes the message to: DETAIL: Labels must be 63 bytes or less. This matches the documentation, which states:

Re: [patch] ENUM errdetail should mention bytes, not chars

2020-10-18 Thread Julien Rouhaud
On Mon, Oct 19, 2020 at 12:18 PM Ian Lawrence Barwick wrote: > > Hi > > The errdetail emitted when creating/modifying an ENUM value is misleading: > > postgres=# CREATE TYPE enum_valtest AS ENUM ( > 'foo', > 'ああ' >); > ERR

[patch] ENUM errdetail should mention bytes, not chars

2020-10-18 Thread Ian Lawrence Barwick
Hi The errdetail emitted when creating/modifying an ENUM value is misleading: postgres=# CREATE TYPE enum_valtest AS ENUM ( 'foo', 'ああ' ); ERROR: invalid enum label "ああ" DETAIL: Labels must be 63