Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Robert Haas
On Thu, May 22, 2025 at 12:10 PM Shaik Mohammad Mujeeb wrote: > In my patch, I currently warn and remove invalid GUCs from the hashtable. > However, as you rightly pointed out, some of these could belong to valid but > unregistered prefixes. In such cases, it might not be ideal to remove them >

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Tom Lane
Shaik Mohammad Mujeeb writes: > In my patch, I currently warn and remove invalid GUCs from the hashtable. > However, as you rightly pointed out, some of these could belong to valid but > unregistered prefixes. In such cases, it might not be ideal to remove them > outright. Instead, it could be

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Tom Lane
Srinath Reddy Sadipiralla writes: > Tom, the problem is when the prefix is a typo ,my bad i should have > specified as bogus prefix instead of bogus GUC ,can you please try again > with > "lpgsql.bogus = 1" . [ shrug... ] How do you know that's a bogus prefix? It could perfectly well be a fully

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Shaik Mohammad Mujeeb
Hi David J, > Because any such setting name is perfectly valid (it serves as a placeholder) > and whether it is a typo or just some valid unregistered prefix is not > something the system can know. In my patch, I currently warn and remove invalid GUCs from the hashtable. However, as you rightl

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Srinath Reddy Sadipiralla
On Thu, May 22, 2025 at 9:00 PM Tom Lane wrote: > Srinath Reddy Sadipiralla writes: > > the extension is loaded and then i entered the bogus extension GUC into > > postgresql.conf and restarted, i did not observe any complain/warning . > > Were you looking in the right place? I experimented wit

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Tom Lane
Srinath Reddy Sadipiralla writes: > the extension is loaded and then i entered the bogus extension GUC into > postgresql.conf and restarted, i did not observe any complain/warning . Were you looking in the right place? I experimented with adding shared_preload_libraries = 'plpgsql'#

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Srinath Reddy Sadipiralla
Hi, On Thu, May 22, 2025 at 2:09 AM Tom Lane wrote: > Shaik Mohammad Mujeeb writes: > > Currently, if there's a typo in an extension name while adding a GUC to > postgresql.conf, PostgreSQL server starts up silently without any warning. > This can be misleading, as one might assume the configur

[Util] Warn and Remove Invalid GUCs

2025-05-21 Thread David G. Johnston
On Wednesday, May 21, 2025, Shaik Mohammad Mujeeb wrote: > > Currently, if there's a typo in an extension name while adding a GUC to > postgresql.conf, PostgreSQL server starts up silently without any warning. > Because any such setting name is perfectly valid (it serves as a placeholder) and whe

Re: [Util] Warn and Remove Invalid GUCs

2025-05-21 Thread Tom Lane
Shaik Mohammad Mujeeb writes: > Currently, if there's a typo in an extension name while adding a GUC to > postgresql.conf, PostgreSQL server starts up silently without any warning. > This can be misleading, as one might assume the configuration has been > correctly applied, when in fact the val

[Util] Warn and Remove Invalid GUCs

2025-05-21 Thread Shaik Mohammad Mujeeb
Hi Hackers, Currently, if there's a typo in an extension name while adding a GUC to postgresql.conf, PostgreSQL server starts up silently without any warning. This can be misleading, as one might assume the configuration has been correctly applied, when in fact the value hasn’t been set due to