Re: [RFC] building postgres with meson -v9

2022-07-15 Thread Andres Freund
Hi, On 2022-07-13 08:39:45 +0200, Peter Eisentraut wrote: > On 06.07.22 15:21, Andres Freund wrote: > > > - This patch is for unifying the list of languages in NLS, as > > >previously discussed:https://commitfest.postgresql.org/38/3737/ > > There seems little downside to doing so, so ... > >

Re: [RFC] building postgres with meson -v9

2022-07-14 Thread Andres Freund
Hi, On 2022-07-07 12:09:32 +0200, Peter Eisentraut wrote: > On 06.07.22 15:21, Andres Freund wrote: > > > Here is my rough assessment of where we are with this patch set: > > > > > > 08b4330ded prereq: deal with \ paths in basebackup_to_shell tests. > > > > > > This still needs clarification, pe

Re: [RFC] building postgres with meson -v9

2022-07-13 Thread Peter Eisentraut
On 06.07.22 15:21, Andres Freund wrote: bda6a45bae meson: prereq: Refactor PG_TEST_EXTRA logic in autoconf build I understand the intention behind this, but I think it changes the behavior in an undesirable way. Before this patch, you can go into src/test/ssl/ and run make check manually. This

Re: [RFC] building postgres with meson -v9

2022-07-12 Thread Peter Eisentraut
On 06.07.22 15:21, Andres Freund wrote: - This patch is for unifying the list of languages in NLS, as previously discussed:https://commitfest.postgresql.org/38/3737/ There seems little downside to doing so, so ... This has been committed, so on the next rebase, the languages arguments can

Re: [RFC] building postgres with meson -v9

2022-07-07 Thread Peter Eisentraut
On 06.07.22 15:21, Andres Freund wrote: Here is my rough assessment of where we are with this patch set: 08b4330ded prereq: deal with \ paths in basebackup_to_shell tests. This still needs clarification, per my previous review. Hm. I thought I had explained that bit, but apparently not. Well,

Re: [RFC] building postgres with meson -v9

2022-07-06 Thread Andres Freund
Hi On 2022-07-06 11:03:31 +0200, Peter Eisentraut wrote: > On 01.07.22 11:33, Andres Freund wrote: > > Attached is an updated version of the meson patchset. There has been a > > steady > > stream of incremental work over the last month, with patches from Peter > > Eisentraut and Nazir Yavuz. > >

Re: [RFC] building postgres with meson -v9

2022-07-06 Thread Peter Eisentraut
On 01.07.22 11:33, Andres Freund wrote: Attached is an updated version of the meson patchset. There has been a steady stream of incremental work over the last month, with patches from Peter Eisentraut and Nazir Yavuz. I tried to address the review comments Peter had downthread about the prep pat

Re: [RFC] building postgres with meson -v9

2022-07-01 Thread Andres Freund
Hi, On 2022-07-01 14:01:11 -0500, Justin Pryzby wrote: > vcvarsall isn't needed in cirrus' "check_world" scripts. E.g. for the ecpg tests it isn't, except that we don't currently build ecpg on windows. But I plan to fix that. > I'm missing any way to re/run cirrus only for msbuild OR ninja OR h

Re: [RFC] building postgres with meson -v9

2022-07-01 Thread Justin Pryzby
vcvarsall isn't needed in cirrus' "check_world" scripts. I'm missing any way to re/run cirrus only for msbuild OR ninja OR homegrown with something more granular than "ci-os-only: windows". (The same thing applies to the mingw patch). I'll mail shortly about ccache. -- Justin