Hi,
Small update for posterity:
On 2022-09-09 16:58:36 -0700, Andres Freund wrote:
> I've run this through enough attempts by now that I'm quite confident that the
> problem does not occur when the errormode does not include
> SEM_NOOPENFILEERRORBOX. I'll want a few more runs to be certain, but..
Hi,
On 2022-11-14 17:16:46 -0600, Justin Pryzby wrote:
> On Sun, Aug 28, 2022 at 01:37:41PM -0700, Andres Freund wrote:
> > > You're running tap tests via a python script. There's no problem with
> > > that, but it's different from what's done by the existing makefiles.
> > > I was able to remove
On Sun, Aug 28, 2022 at 01:37:41PM -0700, Andres Freund wrote:
> > You're running tap tests via a python script. There's no problem with
> > that, but it's different from what's done by the existing makefiles.
> > I was able to remove the python indirection - maybe that's better to
> > talk about
On 08.09.22 09:42, Alvaro Herrera wrote:
On 2022-Sep-07, Peter Eisentraut wrote:
A possible drawback is that the intermediate postgres-full.xml file is
10MB, but I guess we're past the point where we are worrying about that
kind of thing.
I think we are, but maybe mark it .PRECIOUS? IIUC t
On 07.09.22 09:53, Peter Eisentraut wrote:
On 07.09.22 09:19, Peter Eisentraut wrote:
This could also be combined with the idea of the postgres.sgml.valid
thing you have in the meson patch set.
I'll finish this up and produce a proper patch.
Something like this.
This does make the rules mor
Hi,
On 2022-09-07 07:00:17 +0200, Peter Eisentraut wrote:
> On 31.08.22 20:11, Andres Freund wrote:
> > > src/port/win32ver.rc.in: This is redundant with src/port/win32ver.rc.
> > > (Note that the latter is also used as an input file for text
> > > substitution. So having another file named *.in
Hi,
On 2022-08-31 11:11:54 -0700, Andres Freund wrote:
> > If the above are addressed, I think this will be just about at the
> > point where the above patches can be committed.
>
> Woo!
There was a lot less progress over the last ~week than I had hoped. The reason
is that I was trying to figure
On 2022-09-08 14:10:45 +0700, John Naylor wrote:
> Okay, done that way.
Thanks!
On 2022-Sep-07, Peter Eisentraut wrote:
> A possible drawback is that the intermediate postgres-full.xml file is
> >10MB, but I guess we're past the point where we are worrying about that
> kind of thing.
I think we are, but maybe mark it .PRECIOUS? IIUC that would prevent it
from being removed
On Wed, Sep 7, 2022 at 3:36 PM Alvaro Herrera wrote:
>
> On 2022-Sep-06, John Naylor wrote:
>
> > Note that the indentation hasn't changed. My thought there: perltidy
> > will be run again next year, at which time it will be part of a listed
> > whitespace-only commit. Any objections, since that c
On 2022-Sep-06, John Naylor wrote:
> Note that the indentation hasn't changed. My thought there: perltidy
> will be run again next year, at which time it will be part of a listed
> whitespace-only commit. Any objections, since that could confuse
> someone before then?
I think a good plan is to co
On 07.09.22 09:19, Peter Eisentraut wrote:
This could also be combined with the idea of the postgres.sgml.valid
thing you have in the meson patch set.
I'll finish this up and produce a proper patch.
Something like this.
This does make the rules more straightforward and avoids repeated
xmlli
On 31.08.22 20:11, Andres Freund wrote:
doc/src/sgml/resolv.xsl: I don't understand what this is doing. Maybe
at least add a comment in the file.
It's only used for building epubs. Perhaps I should extract that into a
separate patch as well? The relevant section is:
#
# epub
#
# This was pre
On 02.09.22 18:57, Andres Freund wrote:
Is it worth running ninja -t missingdeps as a test? At the time we run tests
we'll obviously have built and thus collected "real" dependencies, so we would
have the necessary information to determine whether dependencies are missing.
I think it'd be fine to
On 31.08.22 20:11, Andres Freund wrote:
src/port/win32ver.rc.in: This is redundant with src/port/win32ver.rc.
(Note that the latter is also used as an input file for text
substitution. So having another file named *.in next to it would be
super confusing.)
Yea, this stuff isn't great. I think
On Mon, Sep 5, 2022 at 4:11 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-09-04 13:12:52 +0700, John Naylor wrote:
> > On Fri, Sep 2, 2022 at 11:35 PM Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On 2022-09-02 14:17:26 +0700, John Naylor wrote:
> > > > On Thu, Sep 1, 2022 at 1:12 AM Andres Freu
Hi,
On 2022-09-04 13:12:52 +0700, John Naylor wrote:
> On Fri, Sep 2, 2022 at 11:35 PM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2022-09-02 14:17:26 +0700, John Naylor wrote:
> > > On Thu, Sep 1, 2022 at 1:12 AM Andres Freund wrote:
> > > > [v12]
> > >
> > > +# Build a small utility static lib
On Fri, Sep 2, 2022 at 11:35 PM Andres Freund wrote:
>
> Hi,
>
> On 2022-09-02 14:17:26 +0700, John Naylor wrote:
> > On Thu, Sep 1, 2022 at 1:12 AM Andres Freund wrote:
> > > [v12]
> >
> > +# Build a small utility static lib for the parser. This makes it easier to
> > not
> > +# depend on gram.
Andres Freund writes:
> On 2022-09-02 14:17:26 +0700, John Naylor wrote:
>> + # FIXME: -output option is only available in perl 5.9.3 - but that's
>> + # probably a fine minimum requirement?
>>
>> Since we've retired some buildfarm animals recently, it seems the
>> oldest perl there is 5.14? ..
Hi,
On 2022-09-02 09:35:15 -0700, Andres Freund wrote:
> Part of that is due to some ugly dependencies of src/common on backend headers
> that IMO probably shouldn't exist (e.g. src/common/relpath.c includes
> catalog/pg_tablespace_d.h). Looks like it'd not be hard to get at least the
> _shlib ver
On Thu, Sep 1, 2022 at 1:12 AM Andres Freund wrote:
> [v12]
+# Build a small utility static lib for the parser. This makes it easier to not
+# depend on gram.h already having been generated for most of the other code
+# (which depends on generated headers having been generated). The generation
+#
Hi,
On 2022-08-31 10:28:05 +0200, Peter Eisentraut wrote:
> I found that the perl test modules are not installed. See attached patch to
> correct this.
>
> To the patches:
>
> 4e15ee0e24 Don't hardcode tmp_check/ as test directory for tap tests
> 1a3169bc3f Split TESTDIR into TESTLOGDIR and TESTD
I found that the perl test modules are not installed. See attached
patch to correct this.
To the patches:
4e15ee0e24 Don't hardcode tmp_check/ as test directory for tap tests
1a3169bc3f Split TESTDIR into TESTLOGDIR and TESTDATADIR
It's a bit weird that the first patch changes the meaning of
Hi,
On 2022-08-28 12:08:07 -0500, Justin Pryzby wrote:
> with_temp_install is repeated twice in prove_check:
>
> > Subject: [PATCH v12 02/15] Split TESTDIR into TESTLOGDIR and TESTDATADIR
> >
> > - TESTDIR='$(CURDIR)/tmp_check' $(with_temp_install)
> > PGPORT='6$(DEF_PGPORT)' \
> > + TESTL
with_temp_install is repeated twice in prove_check:
> Subject: [PATCH v12 02/15] Split TESTDIR into TESTLOGDIR and TESTDATADIR
>
>
> - TESTDIR='$(CURDIR)/tmp_check' $(with_temp_install)
> PGPORT='6$(DEF_PGPORT)' \
> + TESTLOGDIR='$(CURDIR)/tmp_check/log' $(with_temp_install) \
>
On Sun, Aug 28, 2022 at 1:39 PM Andres Freund wrote:
> On 2022-08-27 18:02:40 -0700, Andres Freund wrote:
> > FWIW, I did notice that netbsd does have working unnamed semaphores. I don't
> > know how long ago they were added, but they apparently didn't work quite
> > right
> > in 2018 [1]. No mea
Hi,
On 2022-08-27 18:02:40 -0700, Andres Freund wrote:
> FWIW, I did notice that netbsd does have working unnamed semaphores. I don't
> know how long ago they were added, but they apparently didn't work quite right
> in 2018 [1]. No meaningful performance chance in the main regression tests,
> I'l
Hi,
On 2022-08-27 11:04:47 -0700, Andres Freund wrote:
> - choice of semaphore API needs to be cleaned up, that should be easy now, but
> I thought that I needed to get a new version out first
Everytime I look at the existing selection code I get confused, which is part
of why I haven't tackled
28 matches
Mail list logo
