Re: [RFC] building postgres with meson - perl embedding

2022-02-09 Thread Tom Lane
Andres Freund writes: > On 2022-02-08 18:42:33 -0500, Tom Lane wrote: >> I'd be a little inclined to replace it with some rule about stripping '-bE:' >> switches out of the ldopts result. > Similar. That's a lot easier to understand than than -bE ending up stripped by > what we're doing. Should I

Re: [RFC] building postgres with meson - perl embedding

2022-02-09 Thread Andres Freund
Hi, On 2022-02-08 18:42:33 -0500, Tom Lane wrote: > I'd be a little inclined to replace it with some rule about stripping '-bE:' > switches out of the ldopts result. Similar. That's a lot easier to understand than than -bE ending up stripped by what we're doing. Should I do so, or do you want to?

Re: [RFC] building postgres with meson - perl embedding

2022-02-08 Thread Tom Lane
Andres Freund writes: > On 2022-02-07 20:42:09 -0500, Tom Lane wrote: >> ... Peter just copied the logic in 7662419f1. Considering that >> the point of 7662419f1 was to get rid of MakeMaker, maybe we no >> longer needed that at that point. > Yea. And maybe what was broken in 2001 isn't broken an

Re: [RFC] building postgres with meson - perl embedding

2022-02-08 Thread Andrew Dunstan
On 2/7/22 21:40, Tom Lane wrote: > I wrote: >> Andres Freund writes: >>> What is the reason behind subtracting ccdlflags? >> It looks like the coding actually originated here: >> commit f5d0c6cad5bb2706e0e63f3f8f32e431ea428100 > Ah, here's the thread leading up to that: > > https://www.postgresq

Re: [RFC] building postgres with meson - perl embedding

2022-02-07 Thread Andres Freund
Hi, On 2022-02-07 20:42:09 -0500, Tom Lane wrote: > Andres Freund writes: > > What is the reason behind subtracting ccdlflags? > > It looks like the coding actually originated here: > > commit f5d0c6cad5bb2706e0e63f3f8f32e431ea428100 > Author: Bruce Momjian > Date: Wed Jun 20 00:26:06 2001 +00

Re: [RFC] building postgres with meson - perl embedding

2022-02-07 Thread Tom Lane
I wrote: > Andres Freund writes: >> What is the reason behind subtracting ccdlflags? > It looks like the coding actually originated here: > commit f5d0c6cad5bb2706e0e63f3f8f32e431ea428100 Ah, here's the thread leading up to that: https://www.postgresql.org/message-id/flat/200106191206.f5JC6R108

Re: [RFC] building postgres with meson - perl embedding

2022-02-07 Thread Tom Lane
Andres Freund writes: > What is the reason behind subtracting ccdlflags? It looks like the coding actually originated here: commit f5d0c6cad5bb2706e0e63f3f8f32e431ea428100 Author: Bruce Momjian Date: Wed Jun 20 00:26:06 2001 + Apparently, on some systems, ExtUtils::Embed and MakeMake

Re: [RFC] building postgres with meson - perl embedding

2022-02-07 Thread Andres Freund
Hi, I was trying to fix a few perl embedding oddities in the meson patchset. Whenever I have looked at the existing code, I've been a bit confused about the following code/comment in perl.m4: # PGAC_CHECK_PERL_EMBED_LDFLAGS # - # We are after Embed's ldopts, but with