Re: [RFC] building postgres with meson - autogenerated headers

2022-02-08 Thread Peter Eisentraut
On 07.02.22 20:24, Andres Freund wrote: To be honest, I do not really understand the logic behind when autoconf ends up with #defines that define a macro to 0/1 and when a macro ends defined/or not and when we end up with a macro defined to 1 or not defined at all. The default is to define to 1

Re: [RFC] building postgres with meson - autogenerated headers

2022-02-07 Thread Andres Freund
Hi, On 2022-02-07 16:30:53 -0500, Tom Lane wrote: > > A second aspect that I'm wondering about is whether we should try to split > > pg_config.h output a bit: > > TBH I can't get excited about that. I do not think that rebuilding > with different options is a critical path. ccache already does

Re: [RFC] building postgres with meson - autogenerated headers

2022-02-07 Thread Tom Lane
Andres Freund writes: > I've been wondering whether we should try to have the generated pg_config.h > look as similar as possible to autoconf/autoheader's, or not. And whether the > way autoconf/autoheader define symbols makes sense when not using either > anymore. > To be honest, I do not really

Re: [RFC] building postgres with meson - autogenerated headers

2022-02-07 Thread Andres Freund
Hi, I've been wondering whether we should try to have the generated pg_config.h look as similar as possible to autoconf/autoheader's, or not. And whether the way autoconf/autoheader define symbols makes sense when not using either anymore. To be honest, I do not really understand the logic behind