On 2024/09/20 12:00, Hayato Kuroda (Fujitsu) wrote:
Dear members,
(This mail is just a wrap-up)
I found that the final patch was pushed 2 days ago [1] and BF animals say OK for
now. Therefore, I've closed the CF entry as "committed".
Thanks!
We can extend the
feature to other platforms,
Dear members,
(This mail is just a wrap-up)
I found that the final patch was pushed 2 days ago [1] and BF animals say OK for
now. Therefore, I've closed the CF entry as "committed". We can extend the
feature to other platforms, but I think it could be at another thread later.
Thanks everyone for
Dear Fujii-san,
Thanks for reviewing!
> I made a couple of small adjustments and attached the updated version.
> If that's ok, I'll go ahead and commit it.
>
> + Name of the local user mapped to the foreign server of this
> + connection, or "public" if a public mapping is used. I
On 2024/08/08 11:38, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
Thanks for reviewing! PSA new version.
Thanks for updating the patch! LGTM.
I made a couple of small adjustments and attached the updated version.
If that's ok, I'll go ahead and commit it.
+ Name of the local user
Dear Fujii-san,
Thanks for reviewing! PSA new version.
>
> postgres_fdw_get_connections(
>IN check_conn boolean DEFAULT false, OUT server_name text,
>OUT valid boolean, OUT used_in_xact boolean, OUT closed boolean)
>returns setof record
>
> In the documentation, thi
On 2024/08/02 14:56, Hayato Kuroda (Fujitsu) wrote:
I moved the function to connection.c, which uses the SearchSysCache1().
I've tried both ways, and they worked well. One difference is that when we use
the extended ConnCacheEntry approach and the entry has been invalidated, we
cannot
distin
Dear Fujii-san,
> Thanks for updating the patch!
>
> > - Changed the name of new API from `GetUserMappingFromOid` to
> `GetUserMappingByOid`
> >to keep the name consistent with others.
>
> If we expose this function as an FDW helper function, it should return
> a complete UserMapping object,
On 2024/07/29 12:58, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
IIUC, the patch which adds user_name attribute to get_connection() can be
discussed
in later stage, is it right?
No, let's work on the patch at this stage :)
OK, here is a rebased patch.
Thanks for updating the patch
Dear Fujii-san,
> > IIUC, the patch which adds user_name attribute to get_connection() can be
> discussed
> > in later stage, is it right?
>
> No, let's work on the patch at this stage :)
OK, here is a rebased patch.
- Changed the name of new API from `GetUserMappingFromOid` to
`GetUserMapping
Dear Fujii-san,
Thanks for pushing and analyzing the failure!
> The regression.diffs shows that pgfdw_conn_check returned 0 even though
> pgfdw_conn_checkable()
> returned true. This can happen if the "revents" from poll() indicates
> something
> other than
> POLLRDHUP. I think that "revents" co
On 2024/07/26 22:44, Fujii Masao wrote:
On 2024/07/26 17:07, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
Just in case - based on the agreement in [1], I updated patches to keep them
consistent. We can use same pictures for further discussions...
Thanks for updating the patches! I push
On 2024/07/26 17:07, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
Just in case - based on the agreement in [1], I updated patches to keep them
consistent. We can use same pictures for further discussions...
Thanks for updating the patches! I pushed them.
IIUC, the patch which adds user_
Dear Fujii-san,
Just in case - based on the agreement in [1], I updated patches to keep them
consistent. We can use same pictures for further discussions...
IIUC, the patch which adds user_name attribute to get_connection() can be
discussed
in later stage, is it right?
[1]:
https://www.postgre
On 2024/07/26 12:15, Hayato Kuroda (Fujitsu) wrote:
Agreed to add the table. I ran a proofreading tool, and it said below points.
You can revise if they are acceptable.
Yes, I'm okay with these changes. Thanks for the review!
I’ve also made several code improvements, for example adding a
I apologize to post incomplete message, here is a correct version.
Dear Fujii-san,
> Thanks for updating the patches!
>
> I’ve created a new base patch and split the v42-0001 patch into two parts
> to implement the feature and improvements step by step. After pushing these
> patches, I’ll focus
Dear Fujii-san,
>
> Thanks for updating the patches!
>
> I’ve created a new base patch and split the v42-0001 patch into two parts
> to implement the feature and improvements step by step. After pushing these
> patches, I’ll focus on the v42-0002 patch next.
Best regards,
Hayato Kuroda
FUJITSU
On 2024/07/24 20:40, Hayato Kuroda (Fujitsu) wrote:
Attached patches contain above fixes and comment improvements per request from
GPT-4o.
Thanks for updating the patches!
I’ve created a new base patch and split the v42-0001 patch into two parts
to implement the feature and improvements ste
Dear Fujii-san,
> On 2024/07/18 19:49, Hayato Kuroda (Fujitsu) wrote:
> >> Shouldn't this test also check if the returned user_name is valid?
> >
> > You meant to say that we should print the user_name, right? Done.
>
> Yes, I think it's better to test if the value in the user_name column is as
On 2024/07/18 19:49, Hayato Kuroda (Fujitsu) wrote:
Shouldn't this test also check if the returned user_name is valid?
You meant to say that we should print the user_name, right? Done.
Yes, I think it's better to test if the value in the user_name column is as
expected.
- I found an in
Dear Fujii-san,
Hi, long time no see :-).
Thanks for reviewing the patch! PSA new version.
> I've just started reviewing them.
>
> Here are the review comments for 0001 patch:
>
> Do we really need postgres_fdw_verify_connection_all()? The proposed feature
> aims to check if all postgres_fdw co
On 2023/12/12 11:43, Hayato Kuroda (Fujitsu) wrote:
Dear Shubham,
I am failing to apply the latest
Patch-"v39-0001-postgres_fdw-add-postgres_fdw_verify_connection-.patch"
for review. Please find the error I am facing:
D:\Project\Postgres>git am
D:\Project\Patch\v39-0001-postgres_fdw-add-p
Dear Shubham,
>
> I am failing to apply the latest
> Patch-"v39-0001-postgres_fdw-add-postgres_fdw_verify_connection-.patch"
> for review. Please find the error I am facing:
> D:\Project\Postgres>git am
> D:\Project\Patch\v39-0001-postgres_fdw-add-postgres_fdw_verify_connection
> -.patch
> error
On Mon, Dec 11, 2023 at 2:08 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Fujii-san, Tom,
>
> Thank you for giving a suggestion! PSA new version.
>
> > Regarding 0001 patch, on second thought, to me, it seems odd to expose
> > a function that doesn't have anything to directly do with PostgreSQL
> >
Dear hackers,
> Dear Fujii-san, Tom,
>
> Thank you for giving a suggestion! PSA new version.
I have reviewed and revised patches by myself.
* Fix handing of poll() based on the Horiguchi-san's point
* Fix WARNING message that shows user name which is used for connection
* PQconnCheck(), PQconnC
Dear Fujii-san, Tom,
Thank you for giving a suggestion! PSA new version.
> Regarding 0001 patch, on second thought, to me, it seems odd to expose
> a function that doesn't have anything to directly do with PostgreSQL
> as a libpq function. The function simply calls poll() on the socket
> with POL
Fujii Masao writes:
> Regarding 0001 patch, on second thought, to me, it seems odd to expose
> a function that doesn't have anything to directly do with PostgreSQL
> as a libpq function. The function simply calls poll() on the socket
> with POLLRDHUP if it is supported. While it is certainly conve
On 2023/03/13 16:05, Hayato Kuroda (Fujitsu) wrote:
Thank you so much for your reviewing!
Now we can wait comments from senior members and committers.
Thanks for working on this patch!
Regarding 0001 patch, on second thought, to me, it seems odd to expose
a function that doesn't have anythi
Dear Katsuragi-san,
> Hi,
>
> I updated the status of the patch to ready for committer.
>
> regards,
Thank you so much for your reviewing!
Now we can wait comments from senior members and committers.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On 2023-03-10 18:07, Katsuragi Yuta wrote:
On 2023-03-08 13:40, Hayato Kuroda (Fujitsu) wrote:
Dear Vignesh,
Thank you for reviewing! PSA new version.
Hi,
Thank you for the comments, Vignesh.
Thank you for updating the patch, Kuroda-san. This fix looks fine to
me.
And also, there seems no
On 2023-03-08 13:40, Hayato Kuroda (Fujitsu) wrote:
Dear Vignesh,
Thank you for reviewing! PSA new version.
Hi,
Thank you for the comments, Vignesh.
Thank you for updating the patch, Kuroda-san. This fix looks fine to me.
And also, there seems no other comments from this post [1].
So, I'm pl
Dear Vignesh,
Thank you for reviewing! PSA new version.
>
> Few comments:
> 1) There is no handling of forConnCheck in #else HAVE_POLL, if this is
> intentional we could add some comments for the same:
> static int
> -pqSocketPoll(int sock, int forRead, int forWrite, time_t end_time)
> +pqSocke
On Tue, 7 Mar 2023 at 09:53, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Katsuragi-san,
>
> Thank you for reviewing! PSA new version patches.
>
> > I think we can update the status to ready for committer after
> > this fix, if there is no objection.
>
> That's a very good news for me! How about other
Dear Katsuragi-san,
Thank you for reviewing! PSA new version patches.
> I think we can update the status to ready for committer after
> this fix, if there is no objection.
That's a very good news for me! How about other people?
> >> 7. the document of postgres_fdw_verify_connection_states_all
>
Hi Kuroda-san,
Thank you for updating the patch!
I think we can update the status to ready for committer after
this fix, if there is no objection.
7. the document of postgres_fdw_verify_connection_states_all
NULL
+ is returned if the local session does not have connection
caches,
or thi
Dear Katsuragi-san,
Thank you for reviewing! PSA new version.
> >> 4. the code of pqSocketPoll
> >> +#if defined(POLLRDHUP)
> >> + if (forConnCheck)
> >> + input_fd.events |= POLLRDHUP;
> >> +#endif
> >>
> >> I think it is better to use PQconnCheckable() to remove the macro.
> >
> > IIU
Hi Kuroda-san,
Thank you for updating the patch!
4. the code of pqSocketPoll
+#if defined(POLLRDHUP)
+ if (forConnCheck)
+ input_fd.events |= POLLRDHUP;
+#endif
I think it is better to use PQconnCheckable() to remove the macro.
IIUC the macro is needed. In FreeBSD, macOS
Hi Katsuragi-san,
Thank you for reviewing! PSA new version.
> >> I rethought the pqSocketPoll part. Current interpretation of
> >> arguments seems a little bit confusing because a specific pattern
> >> of arguments has a different meaning. What do you think about
> >> introducing a new argument l
Hi Kuroda-san,
Thank you for updating the patch!
I rethought the pqSocketPoll part. Current interpretation of
arguments seems a little bit confusing because a specific pattern
of arguments has a different meaning. What do you think about
introducing a new argument like `int forConnCheck`? This
Dear Katsuragi-san,
Thank you for reviewing! New patch set can be available on [1].
> I rethought the pqSocketPoll part. Current interpretation of
> arguments seems a little bit confusing because a specific pattern
> of arguments has a different meaning. What do you think about
> introducing a ne
Dear Peter,
Thank you for reviewing! PSA new version.
> 1.
> PQconnCheck() function allows to check the status of the socket by polling
> the socket. This function is currently available only on systems that
> support the non-standard POLLRDHUP extension to the poll system call,
> including Linux
Hi Kuroda-san,
Thank you for updating the patch!
On 2023-02-20 15:42, Hayato Kuroda (Fujitsu) wrote:
Dear Katsuragi-san,
Thank you for reviewing! PSA new version.
I rethought the pqSocketPoll part. Current interpretation of
arguments seems a little bit confusing because a specific pattern
of
Here are some review comments for v32-0001.
==
Commit message
1.
PQconnCheck() function allows to check the status of the socket by polling
the socket. This function is currently available only on systems that
support the non-standard POLLRDHUP extension to the poll system call,
including Lin
Dear Peter,
Thank you for reviewing! Latest version can be seen in [1].
> 1.
> PQcanConnCheck seemed like a strange API name. Maybe it can have the
> same prefix as the other?
>
> e.g.
>
> - PQconnCheck()
> - PGconnCheckSupported()
>
> or
>
> - PQconnCheck()
> - PGconnCheckable()
>
I choose
Dear Katsuragi-san,
Thank you for reviewing! PSA new version.
> 0001:
> Extending pqSocketPoll seems to be a better way because we can
> avoid having multiple similar functions. I also would like to hear
> horiguchi-san's opinion whether this matches his expectation.
> Improvements of pqSocketPol
Here is a code review only for patch v31-0001.
==
General Comment
1.
PQcanConnCheck seemed like a strange API name. Maybe it can have the
same prefix as the other?
e.g.
- PQconnCheck()
- PGconnCheckSupported()
or
- PQconnCheck()
- PGconnCheckable()
==
Commit Message
2.
PqconnCheck()
On 2023-02-09 23:39, Hayato Kuroda (Fujitsu) wrote:
Dear Katsuragi-san,
Thank you for reviewing! PSA new version patches.
Thank you for updating the patch! These are my comments,
please check.
0001:
Extending pqSocketPoll seems to be a better way because we can
avoid having multiple similar f
Dear Katsuragi-san,
Thank you for reviewing! PSA new version patches.
> 0001:
> + while (result < 0 && errno == EINTR);
> +
> + if (result < 0)
> + return -1;
>
> this `return -1` is not indented properly.
This part is no longer needed. Please see another discu
Dear Horiguchi-san,
Thank you for checking! The patch will be attached to another mail.
> At Fri, 27 Jan 2023 06:57:01 +, "Hayato Kuroda (Fujitsu)"
> wrote in
> > I found cfbot failure, PSA fixed version.
>
> + Unlike , this function checks socket
> + health. This check is perfo
At Fri, 27 Jan 2023 06:57:01 +, "Hayato Kuroda (Fujitsu)"
wrote in
> I found cfbot failure, PSA fixed version.
+ Unlike , this function checks socket
+ health. This check is performed by polling the socket. This function is
+ currently available only on systems that suppor
On 2023-01-27 15:57, Hayato Kuroda (Fujitsu) wrote:
I found cfbot failure, PSA fixed version.
Sorry for noise.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Hi Kuroda-san,
Thank you for updating the patch! Sorry for the late reply.
0001:
+ while (result < 0 && errno == EINTR);
+
+
I found cfbot failure, PSA fixed version.
Sorry for noise.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
v29-0003-add-test.patch
Description: v29-0003-add-test.patch
v29-0004-add-kqueue-support-for-PQconnCheck-and-PQcanConn.patch
Description: v29-0004-add-kqueue-support-for-PQconnCheck-and-PQc
Dear hackers,
I have updated my patch for error handling and kqueue() support.
Actually I do not have BSD-like machine, but I developed by using github CICD.
I think at first we should focus on 0001-0003, and then work for 0004.
Followings are change notes and my analysis.
0001
* Fix missed rep
Dear Katsuragi-san,
Thank you for reading the patch! PSA new version.
> Thank you for updating the patch!
>
> +/* Check whether the postgres server is still alive or not */
> +extern int PQConnCheck(PGconn *conn);
> +extern int PQCanConnCheck(void);
>
> Aren't these PQconnCheck and PQcanConnChe
On 2023-01-23 14:40, Hayato Kuroda (Fujitsu) wrote:
Dear Ted,
Thanks for reviewing! PSA new version.
For v25-0001-Add-PQConnCheck-and-PQCanConnCheck-to-libpq.patch ,
`pqConnCheck_internal` only has one caller which is quite short.
Can pqConnCheck_internal and PQConnCheck be merged into one fu
Dear Ted,
Thanks for reviewing! PSA new version.
> For v25-0001-Add-PQConnCheck-and-PQCanConnCheck-to-libpq.patch ,
> `pqConnCheck_internal` only has one caller which is quite short.
> Can pqConnCheck_internal and PQConnCheck be merged into one func ?
I divided the function for feature expandab
> Thank you for reviewing! PSA new patch set.
Sorry, I missed the updated file in the patch. New version will be posted soon.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Sat, Jan 21, 2023 at 4:03 AM Hayato Kuroda (Fujitsu) <
kuroda.hay...@fujitsu.com> wrote:
> Dear Katsuragi-san,
>
> Thank you for reviewing! PSA new patch set.
>
> > ## v24-0001-Add-PQConncheck-and-PQCanConncheck-to-libpq.patch
> > +
> > +
> > PQCanConncheckPQCan
> > Conncheck
> > +
> >
Dear Katsuragi-san,
Thank you for reviewing! PSA new patch set.
> ## v24-0001-Add-PQConncheck-and-PQCanConncheck-to-libpq.patch
> +
> +
> PQCanConncheckPQCan
> Conncheck
> +
> +
> + Returns the status of the socket.
>
> Is this description right? I think this description is
On 2023-01-11 19:04, Hayato Kuroda (Fujitsu) wrote:
Dear hackers,
I was not sure, but the cfbot could not be accepted the previous
version.
I made the patch again from HEAD(5f6401) without any changes,
so I did not count up the version number.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Hi,
Dear hackers,
I was not sure, but the cfbot could not be accepted the previous version.
I made the patch again from HEAD(5f6401) without any changes,
so I did not count up the version number.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
v24-0001-Add-PQConncheck-and-PQCanConncheck-to-libpq.patch
Dear Ted,
Thank you for reviewing! PSA new version.
> + /* quick exit if connection cache has been not initialized yet. */
>
> been not initialized -> not been initialized
Fixed.
> +
> (errcode(ERRCODE_CONNECTION_FAILURE),
> +
On Tue, Jan 10, 2023 at 8:26 AM Hayato Kuroda (Fujitsu) <
kuroda.hay...@fujitsu.com> wrote:
> Dear tom,
>
> > I think that it's a really bad idea to require postgres_fdw.sql
> > to have two expected-files: that will be a maintenance nightmare.
> > Please put whatever it is that needs a variant exp
Dear tom,
> I think that it's a really bad idea to require postgres_fdw.sql
> to have two expected-files: that will be a maintenance nightmare.
> Please put whatever it is that needs a variant expected-file
> into its own, hopefully very small and seldom-changed, test script.
> Or rethink whether
"Hayato Kuroda (Fujitsu)" writes:
> Thanks for reporting. PSA rebased version.
> These can be applied work well on my HEAD(bd8d45).
I think that it's a really bad idea to require postgres_fdw.sql
to have two expected-files: that will be a maintenance nightmare.
Please put whatever it is that need
On Tue, 20 Dec 2022 at 07:22, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> PSA rebased patches.
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
92957ed98c5c565362ce665266132a7f08f6b0c0 ===
=== applying pa
Hi,
On 2022-11-25 11:41:45 +, Hayato Kuroda (Fujitsu) wrote:
> Sorry for my late reply. I understood that we got agreement the basic design
> of first version. Thanks!
> I attached new version patches.
This is failing on cfbot / CI, as have prior versions.
https://cirrus-ci.com/github/postg
Hi Hayota Kuroda,
> I (and my company) worried about overnight batch processing that
> contains some accesses to foreign servers. If the transaction is opened
> overnight and
> one of foreign servers is crashed during it, the transaction must be
> rollbacked.
> But there is a possibility that DBA
Hi,
> As far as I can think of, it should probably be a single background task
> > checking whether the server is down. If so, sending an invalidation
> message
> > to all the backends such that related backends could act on the
> > invalidation and throw an error. This is to cover the use-case yo
On Monday, October 17, 2022 9:25 PM Kuroda, Hayato/黒田 隼人
wrote:
> > I mainly followed the steps there and
> > replaced the command "SELECT" for the remote table at 6-9 with "INSERT"
> > command.
> > Then, after waiting for few seconds, the "COMMIT" succeeded like below
> > output, even after the
Dear Osumi-san,
> I mainly followed the steps there and
> replaced the command "SELECT" for the remote table at 6-9 with "INSERT"
> command.
> Then, after waiting for few seconds, the "COMMIT" succeeded like below output,
> even after the server stop of the worker side.
> Additionally, the last r
Dear Horiguchi-san,
> Might be on slight different direction, but it looks to me a bit too
> much to use WaitEventSet to check only if a socket is live or not.
>
> A quick search in the tree told me that we could use pqSocketCheck()
> instead, and I think it would be the something that "could pot
At Mon, 17 Oct 2022 07:27:21 +, "kuroda.hay...@fujitsu.com"
wrote in
> > In other words, a variation of pgfdw_connection_check_internal()
> > could potentially go into interfaces/libpq/libpq-fe.h
> > (backend/libpq/pqcomm.c or src/interfaces/libpq/fe-connect.c).
>
> Hmm, IIUC libpq related
Dear Önder,
Thanks for giving suggestions!
> Still, the reestablish mechanism can be further simplified with
> WL_SOCKET_CLOSED event such as the following (where we should probably
> rename pgfdw_connection_check_internal):
Sounds reasonable.
I think it may be included in this patch. I will try
On Wednesday, October 5, 2022 6:27 PM kuroda.hay...@fujitsu.com
wrote:
> Thanks for giving many comments! Based on off and on discussions, I modified
> my patch.
Here are my other quick review comments on v16.
(1) v16-0001 : definition of a new structure
CheckingRemoteServersCallbackItem can b
Hi,
On Wednesday, October 5, 2022 6:27 PM kuroda.hay...@fujitsu.com
wrote:
> Thanks for giving many comments! Based on off and on discussions, I modified
> my patch.
Thank you for your patch set !
While reviewing and testing the new v16, I've met a possible issue
by slightly adjusting the scen
Hi,
Sounds reasonable. Do you mean that we can add additional GUC like
> "postgres_fdw.initial_check",
> wait WL_SOCKET_CLOSED if the conneciton is found in the hash table, and do
> reconnection if it might be closed, right?
>
>
Alright, it took me sometime to realize that postgres_fdw already has
Dear Önder,
> As far as I can see this patch is mostly useful for detecting the failures
> on the initial remote command. This is especially common when the remote
> server does a failover/switchover and postgres_fdw uses a cached connection
> to access to the remote server.
Sounds reasonable. Do
Hi Hayato Kuroda,
> If the checking function is called not periodically but GetConnection(),
> it means that the health of foreign servers will be check only when remote
> connections are used.
> So following workload described in [1] cannot handle the issue.
>
> BEGIN --- remote operations--- l
Dear Önder,
Thank you for being interest to my patch! Your suggestions will be included to
newer version.
> In other words, what is the trade-off for calling
> pgfdw_connection_check_internal() inside GetConnection() when we are about
> to use a "cached" connection? I think that might simplify t
Hi Hayato Kuroda,
Thanks for the patch. I think there are some non-fdw extensions out there
which could benefit from this logic. That's why I want to first learn some
more about high-level design/goals of the patch a little more.
+/*
> + * Call callbacks for checking remote servers.
> + */
> +voi
Dear Andres,
> This seems to reliably fail on windows. See
Thanks for reporting. Actually this feature cannot be used on Windows machine.
To check the status of each socket that connects to the foreign server,
the socket event WL_SOCKET_CLOSED is used.
The event is only enabled on some OSes, and
Hi,
On 2022-09-21 11:56:56 +, kuroda.hay...@fujitsu.com wrote:
> PSA rebased patches. I reviewed my myself and they contain changes.
> E.g., move GUC-related code to option.c.
This seems to reliably fail on windows. See
https://cirrus-ci.com/task/6454408568373248
https://cirrus-ci.com/github/
Dear Fujii-san,
Thanks for checking!
> These failed to be applied to the master branch cleanly. Could you update
> them?
PSA rebased patches. I reviewed my myself and they contain changes.
E.g., move GUC-related code to option.c.
> + this option relies on kernel events exposed by Linux,
On 2022/03/04 15:17, kuroda.hay...@fujitsu.com wrote:
Hi Hackers,
It's not happy, but I'm not sure about a good solution. I made a timer
reschedule
if connection lost had detected. But if queries in the transaction are quite
short,
catching SIGINT may be fail.
Attached uses another way:
Hi Hackers,
> It's not happy, but I'm not sure about a good solution. I made a timer
> reschedule
> if connection lost had detected. But if queries in the transaction are quite
> short,
> catching SIGINT may be fail.
Attached uses another way: sets pending flags again if DoingCommandRead is tru
Dear Fujii-san,
Thank you for your quick reviewing! I attached new version.
I found previous patches have wrong name. Sorry.
> The connection check timer is re-scheduled repeatedly even while the backend
> is
> in idle state or is running a local transaction that doesn't access to any
> foreign
On 2022/02/22 15:41, kuroda.hay...@fujitsu.com wrote:
Cfbot is still angry because of missing PGDLLIMPORT, so attached.
Thanks for updating the patches!
The connection check timer is re-scheduled repeatedly even while the backend is
in idle state or is running a local transaction that does
Cfbot is still angry because of missing PGDLLIMPORT, so attached.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
v12_0001_add_checking_infrastracture.patch
Description: v12_0001_add_checking_infrastracture.patch
v12_0002_add_health_check.patch
Description: v12_0002_add_health_check.patch
v12_0
Dear Fujii-san,
> cfbot is reporting that the 0002 patch fails to be applied cleanly. Could you
> update
> the patch?
> http://cfbot.cputube.org/patch_37_3388.log
Thanks for reporting and sorry for inconvenience.
I repo was not latest version. Attached can be applied to 52e4f0c
Best Regards,
Ha
On 2022/02/22 11:53, kuroda.hay...@fujitsu.com wrote:
How do you think?
Thanks for updating the patches! I will read them.
cfbot is reporting that the 0002 patch fails to be applied cleanly. Could you
update the patch?
http://cfbot.cputube.org/patch_37_3388.log
Regards,
--
Fujii Masao
Ad
Dear Horiguchi-san, Fujii-san,
> > I understood here as removing following mechanism from core:
> >
> > * disable timeout at end of tx.
> > * skip if held off or read commands
>
> I think we're on the same page. Anyway query cancel interrupt is
> ignored while rading input.
>
> > > - If an exist
Dear Fujii-san,
> Isn't it a very special case where many FDWs use their own user timeouts?
> Could
> you tell me the assumption that you're thinking, especially how many FDWs are
> working?
I came up with the case like star schema, which postgres database connects data
store.
If each dbms are
On 2022/02/17 19:35, kuroda.hay...@fujitsu.com wrote:
Dear Horiguchi-san,
I think we just don't need to add the special timeout kind to the
core. postgres_fdw can use USER_TIMEOUT and it would be suffiction to
keep running health checking regardless of transaction state then fire
query canc
Dear Horiguchi-san,
> I think we just don't need to add the special timeout kind to the
> core. postgres_fdw can use USER_TIMEOUT and it would be suffiction to
> keep running health checking regardless of transaction state then fire
> query cancel if disconnection happens. As I said in the previo
At Thu, 17 Feb 2022 04:32:26 +, "kuroda.hay...@fujitsu.com"
wrote in
> > I understood here as removing following mechanism from core:
> >
> > * disable timeout at end of tx.
>
> While reading again and this part might be wrong.
> Sorry for inconvenience.
> But anyway some codes should be (
Hi, Kuroda-san.
At Thu, 17 Feb 2022 04:11:09 +, "kuroda.hay...@fujitsu.com"
wrote in
> Dear Horiguchi-san,
>
> Thank you for giving your suggestions. I want to confirm your saying.
>
> > FWIW, I'm not sure this feature necessarily requires core support
> > dedicated to FDWs. The core hav
> I understood here as removing following mechanism from core:
>
> * disable timeout at end of tx.
While reading again and this part might be wrong.
Sorry for inconvenience.
But anyway some codes should be (re)moved from core, right?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Horiguchi-san,
Thank you for giving your suggestions. I want to confirm your saying.
> FWIW, I'm not sure this feature necessarily requires core support
> dedicated to FDWs. The core have USER_TIMEOUT feature already and
> FDWs are not necessarily connection based. It seems better if FDWs
At Tue, 1 Feb 2022 23:51:54 +0900, Fujii Masao
wrote in
> This logic sounds complicated to me. I'm afraid that FDW developers
> may a bit easily misunderstand the logic and make the bug in their
> FDW.
> Isn't it simpler to just disable the timeout in core whenever the
> transaction ends whethe
Dear Hackers,
I found patches we depend have been committed, so rebased.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=50e570a59e7f86bb41f029a66b781fc79b8d50f1
In this version there is a little bit change in part of postgres_fdw.
A system checking by WaitEventSetCanReportClosed()
1 - 100 of 122 matches
Mail list logo
