Re: [PoC] Implementation of distinct in Window Aggregates: take two

2024-02-01 Thread vignesh C
On Wed, 8 Nov 2023 at 11:46, Shlok Kyal wrote: > > Hi, > > I went through the Cfbot, and some of the test cases are failing for > this patch. It seems like some tests are crashing: > https://api.cirrus-ci.com/v1/artifact/task/6291153444667392/crashlog/crashlog-postgres.exe_03b0_2023-11-07_10-41-39

Re: [PoC] Implementation of distinct in Window Aggregates: take two

2023-11-07 Thread Shlok Kyal
Hi, I went through the Cfbot, and some of the test cases are failing for this patch. It seems like some tests are crashing: https://api.cirrus-ci.com/v1/artifact/task/6291153444667392/crashlog/crashlog-postgres.exe_03b0_2023-11-07_10-41-39-624.txt [10:46:56.546] Summary of Failures: [10:46:56.546

[PoC] Implementation of distinct in Window Aggregates: take two

2023-08-27 Thread Ankit Pandey
Hi, This is reopening of thread: https://www.postgresql.org/message-id/flat/2ef6b491-1946-b606-f064-d9ea79d91463%40gmail.com#14e0bdb6872c0b26023d532eeb943d3e This is a PoC patch which implements distinct operation in window aggregates (without order by and for single column aggregation, final ver

Re: [PoC] Implementation of distinct in Window Aggregates

2023-08-03 Thread Daniel Gustafsson
> On 11 Jul 2023, at 01:06, Andreas Karlsson wrote: > > On 3/12/23 09:17, Ankit Kumar Pandey wrote: >> Attaching updated patch with a fix for an issue in window function. >> I have also fixed naming convention of patch as last patch had incompatible >> name. > > Hi, > > This patch does not app

Re: [PoC] Implementation of distinct in Window Aggregates

2023-07-10 Thread Andreas Karlsson
On 3/12/23 09:17, Ankit Kumar Pandey wrote: Attaching updated patch with a fix for an issue in window function. I have also fixed naming convention of patch as last patch had incompatible name. Hi, This patch does not apply to master. Could you rebase it and submit it as one patch which app

Re: [PoC] Implementation of distinct in Window Aggregates

2023-03-12 Thread Ankit Kumar Pandey
Attaching updated patch with a fix for an issue in window function. I have also fixed naming convention of patch as last patch had incompatible name. Note: 1. Pending: Investigation of test cases failures. Regards, Ankit diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify

Re: [PoC] Implementation of distinct in Window Aggregates

2023-03-11 Thread Ankit Kumar Pandey
On 04/01/23 18:10, Ankit Kumar Pandey wrote: On 29/12/22 20:58, Ankit Kumar Pandey wrote: > > On 24/12/22 18:22, Ankit Pandey wrote: >> Hi, >> >> This is a PoC patch which implements distinct operation in window >> aggregates (without order by and for single column aggregation, final >> versio

Re: [PoC] Implementation of distinct in Window Aggregates

2023-01-04 Thread Ankit Kumar Pandey
On 29/12/22 20:58, Ankit Kumar Pandey wrote: On 24/12/22 18:22, Ankit Pandey wrote: Hi, This is a PoC patch which implements distinct operation in window aggregates (without order by and for single column aggregation, final version may vary wrt these limitations). Purpose of this PoC is to

Re: [PoC] Implementation of distinct in Window Aggregates

2022-12-29 Thread Ankit Kumar Pandey
On 24/12/22 18:22, Ankit Pandey wrote: Hi, This is a PoC patch which implements distinct operation in window aggregates (without order by and for single column aggregation, final version may vary wrt these limitations). Purpose of this PoC is to get feedback on the approach used and corresp

[PoC] Implementation of distinct in Window Aggregates

2022-12-24 Thread Ankit Pandey
Hi, This is a PoC patch which implements distinct operation in window aggregates (without order by and for single column aggregation, final version may vary wrt these limitations). Purpose of this PoC is to get feedback on the approach used and corresponding implementation, any nitpicking as deeme