Re: [Patch] checksumming-related buglets in pg_verify_checksums/pg_basebackup TAP tests

2019-02-17 Thread Michael Paquier
On Thu, Feb 14, 2019 at 03:07:56PM +0100, Michael Banck wrote: > This also revealed a second bug in the pg_basebackup test suite where > the offset for the corruption in the second file was wrong, so it > actually never got corrupted, and the tests only passed due to the above > twice than expected

[Patch] checksumming-related buglets in pg_verify_checksums/pg_basebackup TAP tests

2019-02-14 Thread Michael Banck
Hi, while hacking on pg_verify_checksums and looking at hexdumps, I noticed that the TAP tests of pg_verify_checksums (and pg_basebackup from which it was copy-pasted) actually write "305c305c[...]" (i.e. literal backslashes and number 0s) instead of "000[...]" into the to-be- corrupted relfilenod