Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-08-23 Thread Bruce Momjian
On Wed, Aug 18, 2021 at 08:27:19PM +0200, Magnus Hagander wrote: > On Wed, Aug 18, 2021 at 8:16 PM Bruce Momjian wrote: > > > > On Wed, Aug 18, 2021 at 02:03:56PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > I think the only question is whether this is a PG 15-only patch or a > > >

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-08-18 Thread Magnus Hagander
On Wed, Aug 18, 2021 at 8:16 PM Bruce Momjian wrote: > > On Wed, Aug 18, 2021 at 02:03:56PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I think the only question is whether this is a PG 15-only patch or a > > > patckpatch to PG 10; I am in favor of the later. > > > > I think you need

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-08-18 Thread Bruce Momjian
On Wed, Aug 18, 2021 at 02:03:56PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I think the only question is whether this is a PG 15-only patch or a > > patckpatch to PG 10; I am in favor of the later. > > I think you need a lot stronger argument that this is a bug > before you consider ba

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-08-18 Thread Tom Lane
Bruce Momjian writes: > I think the only question is whether this is a PG 15-only patch or a > patckpatch to PG 10; I am in favor of the later. I think you need a lot stronger argument that this is a bug before you consider back-patching user-visible behavioral changes.

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-08-18 Thread Bruce Momjian
On Tue, Jun 29, 2021 at 09:28:04AM +0200, Magnus Hagander wrote: > > 1. Since initdb will replace that string, users will never see this > > entry as-is in live databases. So is it worth doing anything? > > It's not entirely uncommon that users copy the .sample file into their > configuration man

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-06-29 Thread Magnus Hagander
On Thu, Jun 24, 2021 at 5:49 PM Tom Lane wrote: > > "zhangj...@fujitsu.com" writes: > > In PostgreSQL 14, The default value of shared_buffers is 128MB, but in > > postgresql.conf.sample, the default value of shared_buffers is 32MB. > > I think the following changes should be made. > > > File: po

RE: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-06-27 Thread zhangj...@fujitsu.com
ified together. Best Regards! Zhangjie -Original Message- From: Tom Lane Sent: Thursday, June 24, 2021 11:50 PM To: Zhang, Jie/张 杰 Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample "zhangj...@fujitsu

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-06-24 Thread Daniel Gustafsson
> On 24 Jun 2021, at 17:49, Tom Lane wrote: > ..if we were going to do anything I think that adjusting both initdb.c and > guc.c to use 128MB might be the most appropriate thing. Ensuring consistency doesn't seem like a bad thing in itself, even if it in practice won't make much difference. --

Re: [Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-06-24 Thread Tom Lane
"zhangj...@fujitsu.com" writes: > In PostgreSQL 14, The default value of shared_buffers is 128MB, but in > postgresql.conf.sample, the default value of shared_buffers is 32MB. > I think the following changes should be made. > File: postgresql\src\backend\utils\misc\ postgresql.conf.sample > #sha

[Patch] change the default value of shared_buffers in postgresql.conf.sample

2021-06-24 Thread zhangj...@fujitsu.com
Hi all In PostgreSQL 14, The default value of shared_buffers is 128MB, but in postgresql.conf.sample, the default value of shared_buffers is 32MB. I think the following changes should be made. File: postgresql\src\backend\utils\misc\ postgresql.conf.sample #shared_buffers = 32MB => #shared_bu