Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Amul Sul
On Fri, Oct 28, 2022 at 10:43 AM Tom Lane wrote: > > David Rowley writes: > > On Fri, 28 Oct 2022 at 16:51, Amul Sul wrote: > >> If we > >> are too sure that the output usually comes in the same order then the > >> ORDER BY clause that exists in other tests seems useless. I am a bit > >> confuse

Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Amul Sul
On Fri, Oct 28, 2022 at 10:28 AM David Rowley wrote: > > On Fri, 28 Oct 2022 at 16:51, Amul Sul wrote: > > > > On Thu, Oct 27, 2022 at 6:54 PM Tom Lane wrote: > > > Please be specific about the circumstances in which the output is > > > unstable for you. With zero information to go on, it seems

Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Tom Lane
David Rowley writes: > On Fri, 28 Oct 2022 at 16:51, Amul Sul wrote: >> If we >> are too sure that the output usually comes in the same order then the >> ORDER BY clause that exists in other tests seems useless. I am a bit >> confused & what could be a possible bug? > You can't claim that if thi

Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread David Rowley
On Fri, 28 Oct 2022 at 16:51, Amul Sul wrote: > > On Thu, Oct 27, 2022 at 6:54 PM Tom Lane wrote: > > Please be specific about the circumstances in which the output is > > unstable for you. With zero information to go on, it seems about as > > likely that this change is masking a bug as that it'

Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Amul Sul
On Thu, Oct 27, 2022 at 6:54 PM Tom Lane wrote: > > Nishant Sharma writes: > > We would like to share a proposal of a patch, where we have added order by > > clause in two select statements in src/test/regress/sql/insert.sql file and > > respective changes in src/test/regress/expected/insert.out

Re: [PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Tom Lane
Nishant Sharma writes: > We would like to share a proposal of a patch, where we have added order by > clause in two select statements in src/test/regress/sql/insert.sql file and > respective changes in src/test/regress/expected/insert.out output file. > This would help in generating output in con

[PROPOSAL] : Use of ORDER BY clause in insert.sql

2022-10-27 Thread Nishant Sharma
Hi, We would like to share a proposal of a patch, where we have added order by clause in two select statements in src/test/regress/sql/insert.sql file and respective changes in src/test/regress/expected/insert.out output file. This would help in generating output in consistent sequence, as somet