On Fri, Aug 21, 2020 at 07:54:13AM +0200, Pierre Giraud wrote:
> It looks good to me too. Thanks a lot!
> Let's not forget to notify Hubert (depesz) once integrated.
Thanks a lot, and sorry for not responding earlier - vacation.
Best regards,
depesz
On 2020/08/22 1:04, Fujii Masao wrote:
On 2020/08/21 23:53, Tom Lane wrote:
Fujii Masao writes:
Pushed. Thanks!
Buildfarm shows this patch has got problems under
-DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2
On 2020/08/21 23:53, Tom Lane wrote:
Fujii Masao writes:
Pushed. Thanks!
Buildfarm shows this patch has got problems under
-DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12
Thanks for the r
Fujii Masao writes:
> Pushed. Thanks!
Buildfarm shows this patch has got problems under
-DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12
regards, tom lane
On 2020/08/21 14:54, Pierre Giraud wrote:
Le 20/08/2020 à 17:41, Fujii Masao a écrit :
On 2020/08/20 22:34, Julien Rouhaud wrote:
On Thu, Aug 20, 2020 at 12:29 PM David Rowley
wrote:
On Thu, 20 Aug 2020 at 19:58, Fujii Masao
wrote:
On 2020/08/20 13:00, David Rowley wrote:
I forgot t
Le 20/08/2020 à 17:41, Fujii Masao a écrit :
>
>
> On 2020/08/20 22:34, Julien Rouhaud wrote:
>> On Thu, Aug 20, 2020 at 12:29 PM David Rowley
>> wrote:
>>>
>>> On Thu, 20 Aug 2020 at 19:58, Fujii Masao
>>> wrote:
On 2020/08/20 13:00, David Rowley wrote:
> I forgot to mention earl
On 2020/08/20 22:34, Julien Rouhaud wrote:
On Thu, Aug 20, 2020 at 12:29 PM David Rowley wrote:
On Thu, 20 Aug 2020 at 19:58, Fujii Masao wrote:
On 2020/08/20 13:00, David Rowley wrote:
I forgot to mention earlier, you'll also need to remove the part in
the docs that mentions BUFFERS re
On Thu, Aug 20, 2020 at 12:29 PM David Rowley wrote:
>
> On Thu, 20 Aug 2020 at 19:58, Fujii Masao wrote:
> >
> > On 2020/08/20 13:00, David Rowley wrote:
> > > I forgot to mention earlier, you'll also need to remove the part in
> > > the docs that mentions BUFFERS requires ANALYZE.
> >
> > Thank
On Thu, 20 Aug 2020 at 19:58, Fujii Masao wrote:
>
> On 2020/08/20 13:00, David Rowley wrote:
> > I forgot to mention earlier, you'll also need to remove the part in
> > the docs that mentions BUFFERS requires ANALYZE.
>
> Thanks for the review! I removed that.
> Attached is the updated version of
On 2020/08/20 17:03, Pierre Giraud wrote:
Can you please show what the plan would look like for?
=# explain (buffers on, summary on, format JSON) select * from t;
With my patch, the following is reported in that case.
=# explain (buffers on, summary on, format JSON) select * from pg_class;
Can you please show what the plan would look like for?
=# explain (buffers on, summary on, format JSON) select * from t;
Le 20/08/2020 à 09:58, Fujii Masao a écrit :
>
>
> On 2020/08/20 13:00, David Rowley wrote:
>> On Thu, 20 Aug 2020 at 03:31, Fujii Masao
>> wrote:
>>> With the patch, for
On 2020/08/20 13:00, David Rowley wrote:
On Thu, 20 Aug 2020 at 03:31, Fujii Masao wrote:
With the patch, for example, whatever "summary" settng is, "buffers on"
displays the planner's buffer usage if it happens.
I forgot to mention earlier, you'll also need to remove the part in
the docs t
On Thu, 20 Aug 2020 at 03:31, Fujii Masao wrote:
> With the patch, for example, whatever "summary" settng is, "buffers on"
> displays the planner's buffer usage if it happens.
I forgot to mention earlier, you'll also need to remove the part in
the docs that mentions BUFFERS requires ANALYZE.
Dav
On Thu, 20 Aug 2020 at 03:31, Fujii Masao wrote:
>
>
>
> On 2020/08/19 19:39, David Rowley wrote:
> > On Wed, 19 Aug 2020 at 21:05, Julien Rouhaud wrote:
> >>
> >> On Wed, Aug 19, 2020 at 08:49:48PM +1200, David Rowley wrote:
> >>> However, I'm not quite sure how we should handle if someone does:
On 2020/08/19 19:39, David Rowley wrote:
On Wed, 19 Aug 2020 at 21:05, Julien Rouhaud wrote:
On Wed, Aug 19, 2020 at 08:49:48PM +1200, David Rowley wrote:
However, I'm not quite sure how we should handle if someone does:
EXPLAIN (BUFFERS on, SUMMARY off). Without the summary, there's no
pla
On Wed, 19 Aug 2020 at 22:39, David Rowley wrote:
> so, maybe we can just error if analyze == off AND buffers == on AND
> summary == off. We likely should pay attention to analyze there as it
> seems perfectly fine to EXPLAIN (ANALYZE, BUFFERS, SUMMARY off). We
> quite often do SUMMARY off for th
On Wed, 19 Aug 2020 at 21:05, Julien Rouhaud wrote:
>
> On Wed, Aug 19, 2020 at 08:49:48PM +1200, David Rowley wrote:
> > However, I'm not quite sure how we should handle if someone does:
> > EXPLAIN (BUFFERS on, SUMMARY off). Without the summary, there's no
> > place to print the buffers, which s
On Wed, Aug 19, 2020 at 08:49:48PM +1200, David Rowley wrote:
> On Wed, 19 Aug 2020 at 19:22, Julien Rouhaud wrote:
> > Hearing no objection, here's a patch to change the output as suggested by
> > Pierre:
> >
> > =# explain (analyze, buffers) select * from pg_class;
> >
On Wed, 19 Aug 2020 at 19:22, Julien Rouhaud wrote:
> Hearing no objection, here's a patch to change the output as suggested by
> Pierre:
>
> =# explain (analyze, buffers) select * from pg_class;
>QUERY PLAN
>
On Tue, Aug 18, 2020 at 10:27:06PM -0500, Justin Pryzby wrote:
> On Fri, Aug 07, 2020 at 02:30:01PM +0200, Pierre Giraud wrote:
> > Hi all,
> >
> > As far as I understand, in the upcoming version 13, information about
> > buffers used during planning is now available in the explain plan.
> >
> >
On Fri, Aug 07, 2020 at 02:30:01PM +0200, Pierre Giraud wrote:
> Hi all,
>
> As far as I understand, in the upcoming version 13, information about
> buffers used during planning is now available in the explain plan.
>
> […]
> Planning Time: 0.203 ms
>Buffers: shared hit=14
> […]
>
> For a m
On Fri, Aug 7, 2020 at 3:51 PM Pierre Giraud wrote:
>
> Le 07/08/2020 à 14:52, Julien Rouhaud a écrit :
> > Hi,
> >
> > On Fri, Aug 7, 2020 at 2:30 PM Pierre Giraud
> > wrote:
> >>
> >> Hi all,
> >>
> >> As far as I understand, in the upcoming version 13, information about
> >> buffers used duri
Le 07/08/2020 à 14:52, Julien Rouhaud a écrit :
> Hi,
>
> On Fri, Aug 7, 2020 at 2:30 PM Pierre Giraud wrote:
>>
>> Hi all,
>>
>> As far as I understand, in the upcoming version 13, information about
>> buffers used during planning is now available in the explain plan.
>
> Indeed.
>
>> […]
>
Hi,
On Fri, Aug 7, 2020 at 2:30 PM Pierre Giraud wrote:
>
> Hi all,
>
> As far as I understand, in the upcoming version 13, information about
> buffers used during planning is now available in the explain plan.
Indeed.
> […]
> Planning Time: 0.203 ms
>Buffers: shared hit=14
> […]
>
> In th
Hi all,
As far as I understand, in the upcoming version 13, information about
buffers used during planning is now available in the explain plan.
[…]
Planning Time: 0.203 ms
Buffers: shared hit=14
[…]
In the JSON format, the data structure is a bit different:
[…]
"Planning": {
"P
25 matches
Mail list logo
