Re: [PATCH v1] [doc] polish the comments of reloptions

2023-10-27 Thread Bruce Momjian
r_gather which is a USERSET parameter > + * that doesn't affect existing plans or queries. > * > * vacuum_truncate can be set at ShareUpdateExclusiveLock because it > * is only used during VACUUM, which uses a ShareUpdateExclusiveLock, > -- > 2.33.0 > > > -- &

Re: [PATCH v1] [doc] polish the comments of reloptions

2022-08-31 Thread Junwang Zhao
thoughts? On Tue, Aug 30, 2022 at 11:56 AM Junwang Zhao wrote: > > When adding an option, we have 5 choices (bool, integer, real, enum, string), > so the comments seem stale. > > There are some sentences missing *at ShareUpdateExclusiveLock*, this > patch adds them to make the sentences complete.

[PATCH v1] [doc] polish the comments of reloptions

2022-08-29 Thread Junwang Zhao
When adding an option, we have 5 choices (bool, integer, real, enum, string), so the comments seem stale. There are some sentences missing *at ShareUpdateExclusiveLock*, this patch adds them to make the sentences complete. One thing I'm not sure is should we use *at ShareUpdateExclusiveLock* or *