Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
James Hilliard writes: > On Thu, Nov 19, 2020 at 9:02 PM Tom Lane wrote: >> True. Also, while actual documentation on -isysroot seems to be damn >> near nonexistent, all the example usages I can find on the net appear >> to put it into both compile and link steps. So maybe we're just doing >> i

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
On Thu, Nov 19, 2020 at 9:02 PM Tom Lane wrote: > > James Hilliard writes: > > On Thu, Nov 19, 2020 at 7:48 PM Tom Lane wrote: > >> Oh, scratch that, I fat-fingered the experiment somehow. The issue > >> is still there. Still, I'm hesitant to apply the fix you suggest, > >> because of the law

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
James Hilliard writes: > On Thu, Nov 19, 2020 at 7:48 PM Tom Lane wrote: >> Oh, scratch that, I fat-fingered the experiment somehow. The issue >> is still there. Still, I'm hesitant to apply the fix you suggest, >> because of the law of unintended consequences. In particular, I'm >> afraid tha

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
On Thu, Nov 19, 2020 at 7:48 PM Tom Lane wrote: > > I wrote: > > However ... it then occurred to me to blow away my ccache and accache, > > and after rebuilding from scratch, everything's fine. So, are you > > using ccache? > > Oh, scratch that, I fat-fingered the experiment somehow. The issue >

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
I wrote: > However ... it then occurred to me to blow away my ccache and accache, > and after rebuilding from scratch, everything's fine. So, are you > using ccache? Oh, scratch that, I fat-fingered the experiment somehow. The issue is still there. Still, I'm hesitant to apply the fix you sugge

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
On Thu, Nov 19, 2020 at 7:20 PM Tom Lane wrote: > > James Hilliard writes: > > On Thu, Nov 19, 2020 at 6:04 PM Tom Lane wrote: > >> The cases we've got in the buildfarm are Xcode 12.0 on Catalina (10.15.7) > >> and Xcode 12.2 on Big Sur (11.0.1 ... although that one is ARM not Intel). > >> Maybe

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
James Hilliard writes: > On Thu, Nov 19, 2020 at 6:04 PM Tom Lane wrote: >> The cases we've got in the buildfarm are Xcode 12.0 on Catalina (10.15.7) >> and Xcode 12.2 on Big Sur (11.0.1 ... although that one is ARM not Intel). >> Maybe you're found some corner case in between those, but I guess

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
On Thu, Nov 19, 2020 at 6:04 PM Tom Lane wrote: > > James Hilliard writes: > > Hmm, maybe it's a more recent issue then, I took the version number > > from the qt patch assuming it was the same issue, I hit it trying to build > > master on Xcode 12.2 Build version 12B45b on Catalina version 10.15

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
James Hilliard writes: > Hmm, maybe it's a more recent issue then, I took the version number > from the qt patch assuming it was the same issue, I hit it trying to build > master on Xcode 12.2 Build version 12B45b on Catalina version 10.15.7. Hm, maybe you're using some unusual configure options

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
I think I figured it out, it only happens on systems where the Xcode version is newer than the OS it seems. See: https://forum.unity.com/threads/il2cpp-macstandalone-and-xcode-11-4.855187/ So looks like the failure happens due to the system sysroot or something like that missing symbols from the

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
On Thu, Nov 19, 2020 at 5:40 PM Tom Lane wrote: > > James Hilliard writes: > > It would appear weak symbol linking is not handled properly without > > 'isysroot' parameter passed to linker. > > Nobody else has reported this problem, so maybe you should tell us > how to reproduce it before you sug

Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread Tom Lane
James Hilliard writes: > It would appear weak symbol linking is not handled properly without > 'isysroot' parameter passed to linker. Nobody else has reported this problem, so maybe you should tell us how to reproduce it before you suggest a build process change. (And yes, we have buildfarm memb

[PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

2020-11-19 Thread James Hilliard
It would appear weak symbol linking is not handled properly without 'isysroot' parameter passed to linker. Fixes: Undefined symbols for architecture x86_64: "___darwin_check_fd_set_overflow", referenced from: _ClientAuthentication in auth.o _pgstat_init in pgstat.o _ServerLoop