On Monday, December 13, 2021 11:53 PM vignesh C wrote:
>
> On Wed, Dec 8, 2021 at 11:07 AM tanghy.f...@fujitsu.com
> wrote:
> >
> > On Wednesday, December 8, 2021 1:49 PM, vignesh C
> wrote:
> >
> > > The patch no longer applies, could you post a rebased patch.
> >
> > Thanks for your kindly re
On Wed, Dec 8, 2021 at 11:07 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, December 8, 2021 1:49 PM, vignesh C wrote:
>
> > The patch no longer applies, could you post a rebased patch.
>
> Thanks for your kindly reminder. Attached a rebased patch.
> Some changes in v4 patch has been fixed b
On Wednesday, December 8, 2021 1:49 PM, vignesh C wrote:
> The patch no longer applies, could you post a rebased patch.
Thanks for your kindly reminder. Attached a rebased patch.
Some changes in v4 patch has been fixed by 5a28324, so I deleted those changes.
Regards,
Tang
v5-0001-Fix-comment
On Sun, Aug 8, 2021 at 4:26 PM tanghy.f...@fujitsu.com
wrote:
>
> On Sunday, August 8, 2021 6:34 PM, vignesh C wrote
> >Thanks for the updated patch, your changes look good to me. You might
> >want to include the commit message in the patch, that will be useful.
>
> Thanks for your kindly suggest
On Sunday, August 8, 2021 6:34 PM, vignesh C wrote
>Thanks for the updated patch, your changes look good to me. You might
>want to include the commit message in the patch, that will be useful.
Thanks for your kindly suggestion.
Updated patch attached. Added the patch commit message with no new fi
On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi
>
> I saw some inaccurate comments for AlterPublicationStmt structure when
> reviewing patches related to publication[1].
>
> The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
> but the comments only sa
Hi
I saw some inaccurate comments for AlterPublicationStmt structure when
reviewing patches related to publication[1].
The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
but the comments only say 'ADD/DROP'. How about add 'SET' to the comments?
typedef struct AlterPubli
On Tue, Aug 3, 2021 at 8:36 AM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, August 2, 2021 11:56 PM vignesh C wrote:
> >
> > Few minor suggestions:
> > 1) Should we change below to "fail - tables can't be added, dropped or
> > set to "FOR ALL TABLES" publications"
> > --- fail - can't add to for
On Monday, August 2, 2021 11:56 PM vignesh C wrote:
>
> Few minor suggestions:
> 1) Should we change below to "fail - tables can't be added, dropped or
> set to "FOR ALL TABLES" publications"
> --- fail - can't add to for all tables publication
> +-- fail - tables can't be added to or dropped fro
On Mon, Aug 2, 2021 at 3:31 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi Hackers
>
> When review and test another patch at [1], I found some comments in existing
> test code of " src/test/regress/sql/publication.sql " is a little bit
> confused.
> Attached a patch to fix them, please take a check.
>
Hi Hackers
When review and test another patch at [1], I found some comments in existing
test code of " src/test/regress/sql/publication.sql " is a little bit confused.
Attached a patch to fix them, please take a check.
Here is the detail:
Existing code:
CREATE TABLE testpub_tbl2 (id serial prim
11 matches
Mail list logo
