Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-06-05 Thread Long Song
Hi, I modified the patch, kept the old call of SlruReportIOError() outside the for-loop, and add a call of erport() with LOG level when file-close failure occurs in the for-loop. Please check whether this modification is appropriate and let me know if there is any problem. Thank you. At 2024-06

Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-06-04 Thread Long Song
Hi Kyotaro, Thank you for the response. At 2024-06-04 14:44:09, "Kyotaro Horiguchi" wrote: >At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" >wrote in >> >> Hi, >> Actually, I still wonder why only the error message >> of the last failure to close the file was recorded. >> For this unu

Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-06-04 Thread Kyotaro Horiguchi
At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" wrote in > > Hi, > Actually, I still wonder why only the error message > of the last failure to close the file was recorded. > For this unusual situation, it is acceptable to > record all failure information without causing > too much loggin

Re:[PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-05-28 Thread Long Song
Hi, Actually, I still wonder why only the error message of the last failure to close the file was recorded. For this unusual situation, it is acceptable to record all failure information without causing too much logging. Was it designed that way on purpose? At 2024-05-25 17:29:00, "Long Song"

[PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-05-25 Thread Long Song
Hi hackers, When I read the code, I noticed that in SimpleLruWriteAll(), only the last error is recorded when the file fails to close. Like the following, ```void SimpleLruWriteAll(SlruCtl ctl, bool allow_redirtied) { SlruShared shared = ctl->shared; SlruWriteAllData fdata;