Re: [PATCH] pgbench - refactor some connection finish/null into common function

2018-03-01 Thread Andres Freund
On 2018-02-21 19:11:15 +, Rady, Doug wrote: > > On 1/30/18, 03:41, "Fabien COELHO" wrote: > Hello Doug, > Hi Fabien, > > > This patch refactors all of the connection state PQfinish() and > NULL’ing into a single function. > > Excludes PQfinish() in doConnect(). > >

Re: [PATCH] pgbench - refactor some connection finish/null into common function

2018-02-21 Thread Rady, Doug
On 1/30/18, 03:41, "Fabien COELHO" wrote: Hello Doug, Hi Fabien, > This patch refactors all of the connection state PQfinish() and NULL’ing into a single function. > Excludes PQfinish() in doConnect(). My 0.02€: The argument could be "PGconn **" instead of

Re: [PATCH] pgbench - refactor some connection finish/null into common function

2018-01-30 Thread Fabien COELHO
Hello Doug, This patch refactors all of the connection state PQfinish() and NULL’ing into a single function. Excludes PQfinish() in doConnect(). My 0.02€: The argument could be "PGconn **" instead of a "CState *"? If so, it may be used in a few more places. What is your opinion? I'm fine w