Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-12 Thread andrey . arapov
September 12, 2022 7:51 AM, "Tom Lane" wrote: > Julien Rouhaud writes: > >> On Sun, Sep 11, 2022 at 06:22:21PM +, andrey.ara...@nixaid.com wrote: >>> Everyone using containerized postgresql image cannot use /var/lib/postgresql >>> as the mountpoint but has to use /var/lib/postgresql/data in

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-12 Thread andrey . arapov
September 11, 2022 12:18 PM, "Julien Rouhaud" wrote: > Hi, > > On Sat, Sep 10, 2022 at 07:14:59PM +, andrey.ara...@nixaid.com wrote: > >> Have slightly improved the logic so that it does not report an error >> "directory \"%s\" exists but is not empty" >> when it is only supposed to warn th

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-11 Thread Tom Lane
Julien Rouhaud writes: > On Sun, Sep 11, 2022 at 06:22:21PM +, andrey.ara...@nixaid.com wrote: >> Everyone using containerized postgresql image cannot use /var/lib/postgresql >> as the mountpoint but has to use /var/lib/postgresql/data instead due to this >> issue [4] due to [5]. > initdb had

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-11 Thread Julien Rouhaud
On Sun, Sep 11, 2022 at 06:22:21PM +, andrey.ara...@nixaid.com wrote: > September 11, 2022 12:18 PM, "Julien Rouhaud" wrote: > > > Hi, > > > > On Sat, Sep 10, 2022 at 07:14:59PM +, andrey.ara...@nixaid.com wrote: > > > >> Have slightly improved the logic so that it does not report an error

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-11 Thread Tom Lane
Julien Rouhaud writes: > On Sat, Sep 10, 2022 at 07:14:59PM +, andrey.ara...@nixaid.com wrote: >> Have slightly improved the logic so that it does not report an error >> "directory \"%s\" exists but is not empty" >> when it is only supposed to warn the user about the mountpoint, without >> exi

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-11 Thread Julien Rouhaud
Hi, On Sat, Sep 10, 2022 at 07:14:59PM +, andrey.ara...@nixaid.com wrote: > > Have slightly improved the logic so that it does not report an error > "directory \"%s\" exists but is not empty" > when it is only supposed to warn the user about the mountpoint, without > exiting. > > To me, my pat

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-11 Thread andrey . arapov
Hi Tom, I've updated the patch by adding the explanation behind and more comments. (please see the attachment) Have slightly improved the logic so that it does not report an error "directory \"%s\" exists but is not empty" when it is only supposed to warn the user about the mountpoint, without e

Re: [PATCH] initdb: do not exit after warn_on_mount_point

2022-09-10 Thread Tom Lane
andrey.ara...@nixaid.com writes: > please find my first patch for PostgreSQL is attached. You haven't explained why you think this would be a good change, or even a safe one. regards, tom lane

[PATCH] initdb: do not exit after warn_on_mount_point

2022-09-10 Thread andrey . arapov
Hello, please find my first patch for PostgreSQL is attached. Kind regards, Andrey Arapov 0001-initdb-do-not-exit-after-warn_on_mount_point.patch Description: Binary data