On Tue Apr 22, 2025 at 17:47:20 GMT +03, Robin Haberkorn wrote:
> Perhaps you can tell me what else is preventing adoption into core. I believe
> that xslt_process() should also accept the `xml` type as an alternative to
> strings. Strings should be kept for backwards compatibility, though. Also,
>
On Thu Apr 24, 2025 at 01:59:10 GMT +03, Tom Lane wrote:
> Hm. I wonder if we couldn't get rid of the
> HAVE_XMLSTRUCTUREDERRORCONTEXT conditionalization. If the
> libxml2 versions that lacked that were "old" in 2011, surely
> they are extinct in the wild by now. I'm thinking that we
> really do
"Robin Haberkorn" writes:
> btw. you wrote that comment in cacd42d62cb2ddf32135b151f627780a5509780f
> back in 2011.
> The commit message also contains some background information.
Hm. I wonder if we couldn't get rid of the
HAVE_XMLSTRUCTUREDERRORCONTEXT conditionalization. If the
libxml2 versio
On Wed Apr 23, 2025 at 00:42:06 GMT +03, Robin Haberkorn wrote:
> /*
> * Legacy error handling mode. err_occurred is never set, we just add the
> * message to err_buf. This mode exists because the xml2 contrib module
> * uses our error-handling infrastructure, but we don't want to change its
>
Hello Tom!
On Tue Apr 22, 2025 at 18:29:02 GMT +03, Tom Lane wrote:
> Hi Robin, thank you for the patch! This has arrived too late to
> be considered for PG v18, but please add the thread to the open
> commitfest
I will do that. But what about the other changes I proposed (xml data type
and hsto
"Robin Haberkorn" writes:
> I forgot the patch of course...
Hi Robin, thank you for the patch! This has arrived too late to
be considered for PG v18, but please add the thread to the open
commitfest
https://commitfest.postgresql.org/53/
so that we don't forget about it for v19, and so that it
I forgot the patch of course...
--
Robin Haberkorn
Senior Software Engineer
B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537
From cc5be302aa4305403b8131f6c22c39e4dfb75bd1 Mon Sep 17 00:00:00 2001
Dear PG hackers,
here is a patch that improves the xslt_process() error handling. Error
handling was one of the points criticized earlier [1] and as far as I
understand it is one of the reasons that xslt_process() was never adopted
into core and contrib/xml2 is considered deprecated since PG 8. Ho
