Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2024-09-12 Thread Thomas Munro
Hi, FYI, people interested in this thread might be interested in pgsql-bugs #18610. There are two related issues here: 1. Some people want to use LSE on modern ARM servers so they want to use -moutline-atomics, which IIUC adds auto-detection logic with fallback code so it can still run on the f

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2022-06-23 Thread Alexander Korotkov
Hi! On Mon, Sep 7, 2020 at 1:12 AM Zidenberg, Tsahi wrote: > First, I apologize for taking so long to answer. This e-mail regretfully got > lost in my inbox. > > On 24/07/2020, 4:17, "Andres Freund" wrote: > > > What does "not significantly affected" exactly mean? Could you post the >

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-30 Thread Tom Lane
"Zidenberg, Tsahi" writes: > On 29/09/2020, 10:21, "Heikki Linnakangas" wrote: >> If it's a good idea to use -moutline-atomics, I would expect the >> compiler or distribution to enable it by default. And as you pointed >> out, many have. > -moutline-atomics is only enabled by defaul

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-30 Thread Heikki Linnakangas
On 30/09/2020 19:04, Zidenberg, Tsahi wrote: Ubuntu 20.04 even turned it off by default for gcc-10, which seems like a compatibility step with the main gcc-9 compiler. Ok, I definitely don't want to override that decision. I'm marking this as Rejected in the commitfest. But thanks for the benc

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-30 Thread Zidenberg, Tsahi
On 29/09/2020, 10:21, "Heikki Linnakangas" wrote: > If it's a good idea to use -moutline-atomics, I would expect the > compiler or distribution to enable it by default. And as you pointed > out, many have. -moutline-atomics is only enabled by default on the gcc-10 branch where it w

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-29 Thread Heikki Linnakangas
On 10/09/2020 09:37, Zidenberg, Tsahi wrote: On 08/09/2020, 1:01, "Tom Lane" wrote: > I wonder what version of gcc you intend this for. AFAICS, older > gcc versions lack this flag at all, while newer ones have it on > by default. (previously sent private reply, sorry) The mou

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-10 Thread Zidenberg, Tsahi
On 08/09/2020, 1:01, "Tom Lane" wrote: > I wonder what version of gcc you intend this for. AFAICS, older > gcc versions lack this flag at all, while newer ones have it on > by default. (previously sent private reply, sorry) The moutline-atomics flag showed substantial enough impro

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-07 Thread Tom Lane
"Zidenberg, Tsahi" writes: > Outline-atomics is a gcc compilation flag that adds runtime detection of > weather or not the cpu supports atomic instructions. CPUs that don't support > atomic instructions will use the old load-exclusive/store-exclusive > instructions. If a different compilation f

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-06 Thread Michael Paquier
On Sun, Sep 06, 2020 at 09:00:02PM +, Zidenberg, Tsahi wrote: > These results show only about 6% performance increase in simple-update, and > very close > performance in other results, most of which could be attributed to benchmark > result jitter. > These results from "well behaved" benchmar

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-09-06 Thread Zidenberg, Tsahi
Hello! First, I apologize for taking so long to answer. This e-mail regretfully got lost in my inbox. On 24/07/2020, 4:17, "Andres Freund" wrote: > What does "not significantly affected" exactly mean? Could you post the > raw numbers? The following tests show benchmark behavior on m6

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-07-23 Thread Andres Freund
Hi, On 2020-07-01 15:40:38 +, Zidenberg, Tsahi wrote: > Outline-atomics is a gcc compilation flag that adds runtime detection > of weather or not the cpu supports atomic instructions. CPUs that > don't support atomic instructions will use the old > load-exclusive/store-exclusive instructions.

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2020-07-07 Thread Zidenberg, Tsahi
On 01/07/2020, 18:40, "Zidenberg, Tsahi" wrote: > Outline-atomics is a gcc compilation flag that adds runtime detection of > weather or not the cpu > supports atomic instructions. CPUs that don't support atomic instructions > will use the old > load-exclusive/store-exclusive instructions. If a