Re: [PATCH] Windows port add support to BCryptGenRandom

2019-12-18 Thread Michael Paquier
On Wed, Dec 18, 2019 at 09:52:07AM +0100, Juan José Santamaría Flecha wrote: > +1, there is a reference in [1] about that is possible to build PostgreSQL > using the GNU compiler tools for older versions of Windows, that should be > also updated. There is actually a little bit more which could be

RE: [PATCH] Windows port add support to BCryptGenRandom

2019-12-18 Thread Ranier Vilela
De: Michael Paquier Enviadas: Quarta-feira, 18 de Dezembro de 2019 02:19 >This looks like a leftover of d9dd406, which has made the code to >require C99. As we don't support compilation with Windows XP and >require Windows 7, we should be able to remove all the dance around >MIN_WINNT in win32.h,

Re: [PATCH] Windows port add support to BCryptGenRandom

2019-12-18 Thread Juan José Santamaría Flecha
On Wed, Dec 18, 2019 at 3:20 AM Michael Paquier wrote: > On Tue, Dec 17, 2019 at 02:20:20PM +, Ranier Vilela wrote: > > As concern [1], at src/include/port/win32.h, the comments still > > references Windows XP and claims about possible MingW break. > > This looks like a leftover of d9dd406, w

Re: [PATCH] Windows port add support to BCryptGenRandom

2019-12-17 Thread Michael Paquier
On Tue, Dec 17, 2019 at 02:20:20PM +, Ranier Vilela wrote: > As concern [1], at src/include/port/win32.h, the comments still > references Windows XP and claims about possible MingW break. This looks like a leftover of d9dd406, which has made the code to require C99. As we don't support compil

RE: [PATCH] Windows port add support to BCryptGenRandom

2019-12-17 Thread Ranier Vilela
De: Michael Paquier Enviadas: Terça-feira, 17 de Dezembro de 2019 04:34 >So, this basically matches with what the MS documents tell us, and my >impression: this API is available down to at least MSVC 2008, which is >much more than what we support on HEAD where one can use MSVC 2013 and >newer versi

Re: [PATCH] Windows port add support to BCryptGenRandom

2019-12-16 Thread Michael Paquier
On Tue, Dec 17, 2019 at 03:57:56AM +, Ranier Vilela wrote: > Windows Vista I believe. > https://github.com/openssl/openssl/blob/master/crypto/rand/rand_win.c > is the primary font and have more information. So, this basically matches with what the MS documents tell us, and my impression: this

RE: [PATCH] Windows port add support to BCryptGenRandom

2019-12-16 Thread Ranier Vilela
De: Michael Paquier Enviadas: Terça-feira, 17 de Dezembro de 2019 03:43 Para: Ranier Vilela Cc: pgsql-hackers@lists.postgresql.org Assunto: Re: [PATCH] Windows port add support to BCryptGenRandom >And looking at this page, it is said that the minimum version >supported by this function is W

Re: [PATCH] Windows port add support to BCryptGenRandom

2019-12-16 Thread Michael Paquier
On Mon, Dec 16, 2019 at 09:18:10PM +, Ranier Vilela wrote: > According to microsoft documentation at: > https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom > The function CryptGenRandom is deprecated, and may can be removed in future > release. > This patch a

RE: [PATCH] Windows port add support to BCryptGenRandom

2019-12-16 Thread Ranier Vilela
Forget Mkvcbuild_v1.patch regards, Ranier Vileladiff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index 275f3bb699..33dc9bf5ad 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -65,7 +65,7 @@ my @frontend_uselibpgcommon = ( my $frontend_extralibs =

[PATCH] Windows port add support to BCryptGenRandom

2019-12-16 Thread Ranier Vilela
Hi, According to microsoft documentation at: https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom The function CryptGenRandom is deprecated, and may can be removed in future release. This patch add support to use BCryptGenRandom. BCryptGenRandom apparently works