Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-09-06 Thread Tom Lane
Alexander Cheshev writes: > [ v4-0001-Support-wildcards-in-LISTEN-command.patch ] I had not been paying much if any attention to this thread. I assumed from the title that it had in mind to allow something like LISTEN "foo%bar"; where the parameter would be interpreted similarly to a LIKE

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-28 Thread Alexander Cheshev
Hi Emanuel, I did a review on the new patch version and I observed that the identifier > passed to the LISTEN command is handled differently between outer and > inner > levels. > We have the following grammar: notify_channel: ColId {

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-21 Thread Emanuel Calvo
Hi Alexander, I did a review on the new patch version and I observed that the identifier passed to the LISTEN command is handled differently between outer and inner levels. When the outer level exceeds the 64 characters limitation, the outer level of the channel name is truncated, but leaves the

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-15 Thread Alexander Cheshev
Hi Emanuel, Changed implementation of the function Exec_UnlistenCommit . v2 of the path contained a bug in the function Exec_UnlistenCommit (added a test case for that) and also it was not implemented in natural to C form using pointers. Now it looks fine and works as expected. In the previous em

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-13 Thread Alexander Cheshev
Hi Emanuel, I did a test over the "UNLISTEN >" behavior, and I'm not sure if this is > expected. > This command I assume should free all the listening channels, however, it > doesn't > seem to do so: TODO “Allow LISTEN on patterns” [1] is a bit vague about that feature. So I didn't implement it

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-09 Thread Emanuel Calvo
Hello there, El vie, 15 mar 2024 a las 9:01, Alexander Cheshev () escribió: > Hello Hackers, > > I have implemented TODO “Allow LISTEN on patterns” [1] and attached > the patch to the email. The patch basically consists of the following > two parts. > > 1. Support wildcards in LISTEN command > >