> On 1 Jul 2020, at 13:34, Daniel Gustafsson wrote:
>
>> On 9 Apr 2020, at 05:54, Craig Ringer wrote:
>
>> Any thoughts here? I'd like to get it merged if possible and I hope my
>> explanation of why I did it that way clears things up.
>
> According to the CFBot patch tester, this fails the t
> On 9 Apr 2020, at 05:54, Craig Ringer wrote:
> Any thoughts here? I'd like to get it merged if possible and I hope my
> explanation of why I did it that way clears things up.
According to the CFBot patch tester, this fails the test_extensions and
test_extdepend test suites. I've marked the p
On Mon, 30 Mar 2020 at 11:50, Craig Ringer wrote:
>
>
> On Mon, 9 Mar 2020, 17:27 Peter Eisentraut, <
> peter.eisentr...@2ndquadrant.com> wrote:
>
>> On 2020-02-07 04:14, Craig Ringer wrote:
>> > The attached patch fixes this by having PGXS resolve
>> > $(EXTENSION).control along the VPATH.
>>
>>
On Mon, 9 Mar 2020, 17:27 Peter Eisentraut, <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-02-07 04:14, Craig Ringer wrote:
> > The attached patch fixes this by having PGXS resolve
> > $(EXTENSION).control along the VPATH.
>
> Simpler patch:
>
> diff --git a/src/makefiles/pgxs.mk b/src/makef
On 2020-02-07 04:14, Craig Ringer wrote:
> The attached patch fixes this by having PGXS resolve
> $(EXTENSION).control along the VPATH.
Simpler patch:
diff --git a/src/makefiles/pgxs.mk b/src/makefiles/pgxs.mk
index 271e7eaba8..1cd750eecd 100644
--- a/src/makefiles/pgxs.mk
+++ b/src/makefiles/pgx
pgxs.mk assumes that if $(EXTENSION) is set, a file
$(EXTENSION).control must exist in the $(srcdir).
Extensions that need to support multiple Pg versions, multiple
variants of the extension, etc may need to template their extension
control file. PGXS's assumption prevents those extensions from
su