Re: [PATCH] Split varlena.c into varlena.c and bytea.c

2025-06-19 Thread Aleksander Alekseev
Hi Michael, > /* text_name() > * Converts a text type to a Name type. > */ > > Not related to this patch, sorry for the regression, just noticed > a nit while looking at the diffs of what you have here.. This one, as > well as name_text(), uses a comment block that is inconsistent with > the fo

Re: [PATCH] Split varlena.c into varlena.c and bytea.c

2025-06-17 Thread Michael Paquier
On Mon, Jun 16, 2025 at 01:33:20PM +0300, Aleksander Alekseev wrote: > Thanks, fixed. clangd complained that utils/fmgroids.h is not going to > be used, as it complained about funcapi.h before. So I choose not to > include fmgroids.h. v3 seems sensible here. Thanks for the updated patch. /* text

Re: [PATCH] Split varlena.c into varlena.c and bytea.c

2025-06-16 Thread Aleksander Alekseev
Hi Peter, > >> The proposed patch extracts the code dealing with bytea from varlena.c > >> into a separate file, as proposed previously [1]. It merely changes > >> the location of the existing functions. There are no other changes. > > > > Rebased. > > I think this is reasonable. varlena.c is pre

Re: [PATCH] Split varlena.c into varlena.c and bytea.c

2025-06-05 Thread Peter Eisentraut
On 31.03.25 17:29, Aleksander Alekseev wrote: The proposed patch extracts the code dealing with bytea from varlena.c into a separate file, as proposed previously [1]. It merely changes the location of the existing functions. There are no other changes. Rebased. I think this is reasonable. va

Re: [PATCH] Split varlena.c into varlena.c and bytea.c

2025-03-31 Thread Aleksander Alekseev
> The proposed patch extracts the code dealing with bytea from varlena.c > into a separate file, as proposed previously [1]. It merely changes > the location of the existing functions. There are no other changes. Rebased. -- Best regards, Aleksander Alekseev From 86776455a7b82f8cad6b984d3ddd67fc

[PATCH] Split varlena.c into varlena.c and bytea.c

2025-03-25 Thread Aleksander Alekseev
Hi, The proposed patch extracts the code dealing with bytea from varlena.c into a separate file, as proposed previously [1]. It merely changes the location of the existing functions. There are no other changes. [1]: http://postgr.es/m/Zy2UqcZS2XAXBibq%40paquier.xyz -- Best regards, Aleksander A