Benjie Gillam writes:
>> Your patch has two warnings because you are trying to map a policy
>> info pointer to a trigger info pointer:
> Ah, thank you for the pointer (aha); I've attached an updated patch
> that addresses this copy/paste issue.
LGTM, pushed (with a bit of extra polishing of comm
> Thanks. Perhaps you could add your patch to the next commit fest
> then at https://commitfest.postgresql.org/25/?
Thanks, submitted.
On Tue, Sep 24, 2019 at 08:48:33AM +0100, Benjie Gillam wrote:
> Here we create two identically named triggers and two identically
> named policies on tables foo and bar. If instead we ran these
> statements in a different order (or if the object IDs were to wrap)
> the order of the pg_dump would b
1ff320628f541f330ac2d0 Mon Sep 17 00:00:00 2001
From: Benjie Gillam
Date: Mon, 23 Sep 2019 21:18:24 +0100
Subject: [PATCH] Sort policies and triggers by table name in pg_dump.
To: pgsql-hack...@postgresql.org
---
src/bin/pg_dump/pg_dump_sort.c | 22 ++
1 file changed, 22 inser
On Mon, Sep 23, 2019 at 10:34:07PM +0100, Benjie Gillam wrote:
> The attached draft patch (made against `pg_dump_sort.c` on master) breaks
> ties for trigger and policy objects by using the table name, increasing the
> sort order stability. I have compiled it and executed it against a number of
> l
: Mon, 23 Sep 2019 21:18:24 +0100
Subject: [PATCH] Sort policies and triggers by table name in pg_dump.
To: pgsql-hack...@postgresql.org
---
src/bin/pg_dump/pg_dump_sort.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/bin/pg_dump/pg_dump_sort.c b/src/bin/pg_dump
