Onur Tirtir writes:
> Thank you for sharing your proposal as a patch. It looks much nicer and
> useful than mine.
> I've also tested it for a few cases --by injecting a memory error on
> purpose-- and seen that it helps reporting the problematic query.
> Should we move forward with v3 then?
OK,
rg
Subject: Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a
memory error under Valgrind
[You don't often get email from t...@sss.pgh.pa.us. Learn why this is important
at https://aka.ms/LearnAboutSenderIdentification ]
Onur Tirtir writes:
> Thank you for reviewing t
Onur Tirtir writes:
> Thank you for reviewing the patch and for your feedback. I believe the v2
> patch should be able to handle other protocol messages too.
I like the concept here, but the reporting that the v2 patch provides
would be seriously horrid: it's trying to print stuff that isn't
nec
Subject: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory
error under Valgrind
[You don't often get email from peter.eisentr...@enterprisedb.com. Learn why
this is important at https://aka.ms/LearnAboutSenderIdentification ]
On 31.01.23 15:00, Onur Tirtir wrote:
> We use
On 31.01.23 15:00, Onur Tirtir wrote:
We use Valgrind --together with the suppression file provided in
Postgres repo-- to test Citus extension against memory errors.
We replace /bin/postgres executable with a simple bash script that
executes the original postgres executable under Valgrind and
We use Valgrind --together with the suppression file provided in Postgres
repo-- to test Citus extension against memory errors.
We replace /bin/postgres executable with a simple bash script that executes the
original postgres executable under Valgrind and then we run our usual
regression tests.
