Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
David CARLIER writes: > I m not against, I would go with your final version too. Thanks ! Pushed to all supported branches. regards, tom lane

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread David CARLIER
I m not against, I would go with your final version too. Thanks ! On 20 November 2017 at 22:36, Tom Lane wrote: > I wrote: > > I still dare to doubt whether you've tested this, because AFAICS > > the operand numbering is wrong. The "r"(lock) operand is number 3 > > given these operand declarati

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
I wrote: > I still dare to doubt whether you've tested this, because AFAICS > the operand numbering is wrong. The "r"(lock) operand is number 3 > given these operand declarations, not number 2. Oh, my apologies, scratch that. Evidently I put in the "+m"(*lock) operand and confused myself about w

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
David CARLIER writes: > On 20 November 2017 at 18:49, Tom Lane wrote: >> OTOH, we still have M68K >> and VAX stanzas in that file, so I suppose it's silly to complain >> about 88K. A bigger issue is that I wonder whether that code has >> ever been tested: it does not look to me like the __asm__

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread David Fetter
On Mon, Nov 20, 2017 at 06:57:47PM +, David CARLIER wrote: > On 20 November 2017 at 18:49, Tom Lane wrote: > > > David CARLIER writes: > > > - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if > > > those small changes make sense for the PostgreSQL developers. > > > > Hm

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread David CARLIER
On 20 November 2017 at 18:49, Tom Lane wrote: > David CARLIER writes: > > - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if > > those small changes make sense for the PostgreSQL developers. > > Hm. The s_lock.c change is surely fine if OpenBSD maintainers say it is. > > N

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
David CARLIER writes: > - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if > those small changes make sense for the PostgreSQL developers. Hm. The s_lock.c change is surely fine if OpenBSD maintainers say it is. Not sure about adding Motorola 88K support to s_lock.h ... is

[PATCH] Porting small OpenBSD changes.

2017-11-20 Thread David CARLIER
Hi, Compilation pass, make check passes. Motivations : - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if those small changes make sense for the PostgreSQL developers. Hope it is good. Thanks in advance. Kind regards. 0001-PATCH-1-1-Porting-OpenBSD-internal-changes.pat