On Mon, Jul 14, 2025 at 9:10 AM Michael Paquier wrote:
>
> On Thu, Jul 10, 2025 at 02:21:38PM +0900, Michael Paquier wrote:
> > After that, I have applied a few cosmetic tweaks here and there, and
> > attached is what I have staged for commit, minus proper commit
> > messages. The new TAP tests h
On Thu, Jul 10, 2025 at 02:21:38PM +0900, Michael Paquier wrote:
> After that, I have applied a few cosmetic tweaks here and there, and
> attached is what I have staged for commit, minus proper commit
> messages. The new TAP tests have some WIN32-specific things, and I
> won't be able to look at t
On Wed, Jul 09, 2025 at 04:31:31PM +0900, Michael Paquier wrote:
> Attached is a rebased version of the rest, with the recent stanza
> related to fef6da9e9c87 taken into account. 0002 still has a change
> that should be in 0001: I have not really touched the structure of the
> two remaining patche
On Fri, Jun 27, 2025 at 09:25:47PM +0900, Ryo Kanbayashi wrote:
> I've attached modified and splited patch files to this mail.
Taken in isolation, 0001 was incorrect because it still contained the
case of "servicefile" nested to a service file, but this code path is
only introduced in 0002. I hav
On Wed, Jun 18, 2025 at 12:23 PM Michael Paquier wrote:
> While testing the patch, I've bumped into this scenario which feels
> incomplete:
> - Rely on a default location of the service file, like
> $HOME/.pg_service.conf.
> - Define a service, with PGSERVICE or a connection parameter.
> In this c
On Sun, Jun 15, 2025 at 09:02:31PM +0900, Ryo Kanbayashi wrote:
> Thanks for review :)
Thanks for the new patch.
While testing the patch, I've bumped into this scenario which feels
incomplete:
- Rely on a default location of the service file, like
$HOME/.pg_service.conf.
- Define a service, with
On Tue, Jun 10, 2025 at 4:30 PM Michael Paquier wrote:
>
> On Mon, Jun 09, 2025 at 10:25:26PM +0900, Ryo Kanbayashi wrote:
> >> This could be a patch built on top of the introduction of the core API
> >> for the service file.
> >
> > :)
>
> >> - Perhaps a shortcut for PROMPT?
> >
> > I will kindly
On Mon, Jun 09, 2025 at 10:25:26PM +0900, Ryo Kanbayashi wrote:
>> This could be a patch built on top of the introduction of the core API
>> for the service file.
>
> :)
>> - Perhaps a shortcut for PROMPT?
>
> I will kindly take a rain check on this one :)
I am not sure to understand what you m
On Wed, Jun 4, 2025 at 1:42 PM Michael Paquier wrote:
>
> On Sun, Jun 01, 2025 at 09:36:08PM +0900, Ryo Kanbayashi wrote:
> > Strictly speaking, in a Windows environment, a path containing a
> > backslash is stored in the $td variable, so the value of the
> > $srvfile_valid variable, which contain
On Sun, Jun 01, 2025 at 09:36:08PM +0900, Ryo Kanbayashi wrote:
> Strictly speaking, in a Windows environment, a path containing a
> backslash is stored in the $td variable, so the value of the
> $srvfile_valid variable, which contains that path, also needs to be
> converted.
> If conversion is not
On Wed, May 28, 2025 at 3:48 PM Michael Paquier wrote:
>
> On Sun, Apr 13, 2025 at 07:06:06PM +0900, Ryo Kanbayashi wrote:
> > I rebased our patch according to 2c7bd2ba507e.
> > https://commitfest.postgresql.org/patch/5387/
>
> Thanks for the new version.
Thanks for review :)
> -# for the conne
On Sun, Apr 13, 2025 at 07:06:06PM +0900, Ryo Kanbayashi wrote:
> I rebased our patch according to 2c7bd2ba507e.
> https://commitfest.postgresql.org/patch/5387/
Thanks for the new version.
-# for the connection options and their environment variables.
+# for the connection options, servicefile o
On Mon, Apr 7, 2025 at 1:10 PM Michael Paquier wrote:
>
> On Thu, Apr 03, 2025 at 12:36:59AM +0900, Ryo Kanbayashi wrote:
> > I'll reflect your notice and suggestion to the patch current I'm
> > working on :)
>
> Thanks for that.
>
> And I have forgotten to add you as a reviewer of what has been
>
On Thu, Apr 03, 2025 at 12:36:59AM +0900, Ryo Kanbayashi wrote:
> I'll reflect your notice and suggestion to the patch current I'm
> working on :)
Thanks for that.
And I have forgotten to add you as a reviewer of what has been
committed as 2c7bd2ba507e. Sorry for that :/
--
Michael
signature.a
On Mon, Mar 31, 2025 at 04:26:27PM -0500, Andrew Jackson wrote:
> I am working on a feature adjacent to the connection service functionality
> and noticed some issues with the tests introduced in this thread. Basically
> they incorrectly invoke the append perl function by passing multiple
> strings
On Tue, Apr 1, 2025 at 6:26 AM Andrew Jackson
wrote:
>
> Hi,
>
> I am working on a feature adjacent to the connection service functionality
> and noticed some issues with the tests introduced in this thread. Basically
> they incorrectly invoke the append perl function by passing multiple strings
Hi,
I am working on a feature adjacent to the connection service functionality
and noticed some issues with the tests introduced in this thread. Basically
they incorrectly invoke the append perl function by passing multiple
strings to append when the function only takes one string to append. This
On Sat, Mar 29, 2025 at 3:35 PM Ryo Kanbayashi wrote:
> On Fri, Mar 28, 2025 at 8:57 AM Michael Paquier wrote:
> > > I am not sure that I'll have the time to look at 0002 for this release
> > > cycle, could it be possible to get a rebase for it?
> > Here is a simple rebase that I have been able t
On Fri, Mar 28, 2025 at 10:44 AM Michael Paquier wrote:
>
> On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote:
> > With all that in mind and more documentation added to the test, I've
> > applied 0001, so let's see what the buildfarm has to say. The CI was
> > stable, so it's a star
On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote:
> With all that in mind and more documentation added to the test, I've
> applied 0001, so let's see what the buildfarm has to say. The CI was
> stable, so it's a start.
The buildfarm (particularly the Windows members that worried me
On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote:
> I am not sure that I'll have the time to look at 0002 for this release
> cycle, could it be possible to get a rebase for it?
Here is a simple rebase that I have been able to assemble this
morning. I won't have the space to review
On Sun, Mar 23, 2025 at 12:32:03PM +0900, Ryo Kanbayashi wrote:
> Additional test scripts have been merged to a single script ^^ b
I have spent quite a bit of time on the review 0001 with the new
tests to get something in for this release, and there was quite a bit
going on there:
- The script sho
On Sat, Mar 22, 2025 at 4:46 PM Michael Paquier wrote:
>
> On Thu, Mar 20, 2025 at 06:16:44PM +0900, Ryo Kanbayashi wrote:
> > Sorry, I found a miss on 006_service.pl.
> > Fixed patch is attached...
>
> Please note that the commit fest app needs all the patches of a a set
> to be posted in the sam
On Thu, Mar 20, 2025 at 06:16:44PM +0900, Ryo Kanbayashi wrote:
> Sorry, I found a miss on 006_service.pl.
> Fixed patch is attached...
Please note that the commit fest app needs all the patches of a a set
to be posted in the same message. In this case, v2-0001 is not going
to get automatic test
On Thu, Mar 20, 2025 at 5:39 PM Ryo Kanbayashi wrote:
>
> On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote:
> > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > > Putting a bit of context here. Most of the Postgres hackers based in
> > > Japan had a meeting last Friday, a
25 matches
Mail list logo
