Re: [PATCH] Log CSV by default

2018-12-03 Thread Gilles Darold
Le 04/12/2018 à 03:37, Michael Paquier a écrit : > On Mon, Dec 03, 2018 at 09:20:01PM +0100, Gilles Darold wrote: >> pgBadger is able to parse jsonlog >> (https://github.com/michaelpq/pg_plugins/tree/master/jsonlog) output in >> multi-process mode because it do not use an external library to parse

Re: [PATCH] Log CSV by default

2018-12-03 Thread Michael Paquier
On Mon, Dec 03, 2018 at 09:20:01PM +0100, Gilles Darold wrote: > pgBadger is able to parse jsonlog > (https://github.com/michaelpq/pg_plugins/tree/master/jsonlog) output in > multi-process mode because it do not use an external library to parse > the json. In this minimalist implementation I assume

Re: [PATCH] Log CSV by default

2018-12-03 Thread Gilles Darold
Le 03/12/2018 à 19:25, David Fetter a écrit : > On Mon, Dec 03, 2018 at 07:18:31PM +0100, Gilles Darold wrote: >> Le 30/11/2018 à 19:53, David Fetter a écrit : >>> This makes it much simpler for computers to use the logs while not >>> making it excessively difficult for humans to use them. >> I'm a

Re: [PATCH] Log CSV by default

2018-12-03 Thread David Fetter
On Mon, Dec 03, 2018 at 07:18:31PM +0100, Gilles Darold wrote: > Le 30/11/2018 à 19:53, David Fetter a écrit : > > This makes it much simpler for computers to use the logs while not > > making it excessively difficult for humans to use them. > > I'm also not very comfortable with this change. For

Re: [PATCH] Log CSV by default

2018-12-03 Thread Gilles Darold
Le 30/11/2018 à 19:53, David Fetter a écrit : > This makes it much simpler for computers to use the logs while not > making it excessively difficult for humans to use them. I'm also not very comfortable with this change. For a pgBadger point of view I don't know an existing library to parse csv l

Re: [PATCH] Log CSV by default

2018-12-02 Thread David Fetter
On Sun, Dec 02, 2018 at 12:09:57PM -0500, Tom Lane wrote: > Arkhena writes: > > As a consultant with so many customers that simply install Postgres "out of > > the box", I think that changing log_destination to 'csvlog' and > > logging_collector to 'on' needs changing at least log_truncate_on_rota

Re: [PATCH] Log CSV by default

2018-12-02 Thread Tom Lane
Arkhena writes: > As a consultant with so many customers that simply install Postgres "out of > the box", I think that changing log_destination to 'csvlog' and > logging_collector to 'on' needs changing at least log_truncate_on_rotation > (but certainly also log_filename and log_rotation_age) if w

Re: [PATCH] Log CSV by default

2018-12-02 Thread Arkhena
Hi all, > Also, in addition to the objections you noted, there's the problem that > this change requires changing logging_collector to default to "on". > That's an *enormous* compatibility break, because of the effects on > where the log output goes. > As a consultant with so many customers that

Re: [PATCH] Log CSV by default

2018-12-01 Thread Vik Fearing
On 30/11/2018 21:15, Andres Freund wrote: > Secondarily, csvlog doesn't contain all the interesting information. It doesn't? What is it missing? -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Re: [PATCH] Log CSV by default

2018-11-30 Thread David Fetter
On Fri, Nov 30, 2018 at 04:55:30PM -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-11-30 19:53:18 +0100, David Fetter wrote: > >> This makes it much simpler for computers to use the logs while not > >> making it excessively difficult for humans to use them. > > > While perhaps not exce

Re: [PATCH] Log CSV by default

2018-11-30 Thread Michael Paquier
On Fri, Nov 30, 2018 at 06:11:03PM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> I think we should reject this out of hand. > > Agreed. +1. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Log CSV by default

2018-11-30 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Andres Freund writes: > > On 2018-11-30 19:53:18 +0100, David Fetter wrote: > >> This makes it much simpler for computers to use the logs while not > >> making it excessively difficult for humans to use them. > > > While perhaps not excessively

Re: [PATCH] Log CSV by default

2018-11-30 Thread Tom Lane
Andres Freund writes: > On 2018-11-30 19:53:18 +0100, David Fetter wrote: >> This makes it much simpler for computers to use the logs while not >> making it excessively difficult for humans to use them. > While perhaps not excessively so, I think it increases the difficulty > sufficiently that I'

Re: [PATCH] Log CSV by default

2018-11-30 Thread Isaac Morland
> I think having a bin/pg_logparse tool that can parse postgres' config > file and attempt to parse the log contents in whatever format they are > would be much much more useful. Obviously not every log_line_prefix can > be parsed unambiguously, but a lot of formats can, and a lot more > formats ca

Re: [PATCH] Log CSV by default

2018-11-30 Thread Andres Freund
Hi, On 2018-11-30 19:53:18 +0100, David Fetter wrote: > This makes it much simpler for computers to use the logs while not > making it excessively difficult for humans to use them. While perhaps not excessively so, I think it increases the difficulty sufficiently that I'm against such a proposal.