Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-27 Thread Greg Burd
On 7/25/25 15:02, Greg Burd wrote: > Patch set is now: > > 1) remove freelist > > 2) remove buffer_strategy_lock > > 3) abstract clock-sweep to type and API > > > > -greg Somehow including the test.c file as an attachment on my last email confused the CI and it didn't test the v10 patch set (which

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-25 Thread Greg Burd
On 7/22/25 14:43, Greg Burd wrote: > On 7/21/25 14:35, Andres Freund wrote: >> Hi, >> >> On 2025-07-21 13:37:04 -0400, Greg Burd wrote: >>> On 7/18/25 13:03, Andres Freund wrote: >>> Hello.  Thanks again for taking the time to review the email and patch, >>> I think we're onto something good here.

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-22 Thread Greg Burd
On 7/21/25 14:35, Andres Freund wrote: > Hi, > > On 2025-07-21 13:37:04 -0400, Greg Burd wrote: >> On 7/18/25 13:03, Andres Freund wrote: >> Hello.  Thanks again for taking the time to review the email and patch, >> I think we're onto something good here. >> >>> I'd be curious if anybody wants to a

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-21 Thread Andres Freund
Hi, On 2025-07-21 13:37:04 -0400, Greg Burd wrote: > On 7/18/25 13:03, Andres Freund wrote: > Hello.  Thanks again for taking the time to review the email and patch, > I think we're onto something good here. > > > > > I'd be curious if anybody wants to argue for keeping the clock sweep. Except >

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-21 Thread Greg Burd
On 7/18/25 13:03, Andres Freund wrote: > Hi, Hello.  Thanks again for taking the time to review the email and patch, I think we're onto something good here. > > I'd be curious if anybody wants to argue for keeping the clock sweep. Except > for the have_free_buffer() use in autoprewarm, it's a rat

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-18 Thread Andres Freund
Hi, I'd be curious if anybody wants to argue for keeping the clock sweep. Except for the have_free_buffer() use in autoprewarm, it's a rather trivial patch. And I really couldn't measure regressions above the noise level, even if absurdly extreme use cases. On 2025-07-17 14:35:13 -0400, Greg Bur

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-17 Thread Greg Burd
On Fri, Jul 11, 2025, at 2:52 PM, Andres Freund wrote: Hi, On 2025-07-11 13:26:53 -0400, Greg Burd wrote: In conversations [1] recently about considering how best to adapt the code to become NUMA-aware Andres commented, "FWIW, I've started to wonder if we shouldn't just get rid of the freelis

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Greg Burd
On Fri, Jul 11, 2025, at 2:50 PM, Nathan Bossart wrote: > On Fri, Jul 11, 2025 at 01:26:53PM -0400, Greg Burd wrote: >> This change does remove the have_free_buffer() function used by the >> contrib/pg_prewarm module. On the surface this doesn't seem to cause any >> issues, but honestly I've not

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Andres Freund
Hi, On 2025-07-11 13:26:53 -0400, Greg Burd wrote: > In conversations [1] recently about considering how best to adapt the code > to become NUMA-aware Andres commented, "FWIW, I've started to wonder if we > shouldn't just get rid of the freelist entirely" and because I'm a glutton > for punishment

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Nathan Bossart
On Fri, Jul 11, 2025 at 01:26:53PM -0400, Greg Burd wrote: > This change does remove the have_free_buffer() function used by the > contrib/pg_prewarm module. On the surface this doesn't seem to cause any > issues, but honestly I've not thought too deeply on this one. Hm. ISTM we'll either need t

[PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Greg Burd
Hello, In conversations [1] recently about considering how best to adapt the code to become NUMA-aware Andres commented, "FWIW, I've started to wonder if we shouldn't just get rid of the freelist entirely" and because I'm a glutton for punishment (and I think this idea has some merit) I took hi