Re: [PATCH] Improve error message when trying to lock virtual tuple.

2024-06-18 Thread Matthias van de Meent
On Tue, 18 Jun 2024 at 09:32, Sven Klemm wrote: > > On Mon, Jun 17, 2024 at 10:25 PM Matthias van de Meent > wrote: > > > I think you're solving the wrong problem here, as I can't think of a > > place where both virtual tuple slots and tuple locking are allowed at > > the same time in core code.

Re: [PATCH] Improve error message when trying to lock virtual tuple.

2024-06-18 Thread Sven Klemm
On Mon, Jun 17, 2024 at 10:25 PM Matthias van de Meent wrote: > I think you're solving the wrong problem here, as I can't think of a > place where both virtual tuple slots and tuple locking are allowed at > the same time in core code. > > I mean, in which kind of situation could we get a Relation

Re: [PATCH] Improve error message when trying to lock virtual tuple.

2024-06-17 Thread Matthias van de Meent
(now send a copy to -hackers, too) On Mon, 17 Jun 2024 at 17:55, Sven Klemm wrote: > > Hello, > > When currently trying to lock a virtual tuple the returned error > will be a misleading `could not read block 0`. This patch adds a > check for the tuple table slot being virtual to produce a clearer

Re: [PATCH] Improve error message when trying to lock virtual tuple.

2024-06-17 Thread Aleksander Alekseev
Hi, > When currently trying to lock a virtual tuple the returned error > will be a misleading `could not read block 0`. This patch adds a > check for the tuple table slot being virtual to produce a clearer > error. > > This can be triggered by extensions returning virtual tuples. > While this is o

[PATCH] Improve error message when trying to lock virtual tuple.

2024-06-17 Thread Sven Klemm
an error in those extensions the resulting error is very misleading. -- Regards, Sven Klemm From c5ccbf2e9cb401a7e63e93cd643b4dfec8d92ab8 Mon Sep 17 00:00:00 2001 From: Sven Klemm Date: Mon, 17 Jun 2024 17:38:27 +0200 Subject: [PATCH] Improve error message when trying to lock virtual tuple