Hi,
On this list we quote inline, and trim quoted messages to the relevant
parts...
On 2019-11-13 17:40:27 +, Ranier Vilela wrote:
> "Why is this an improvement? And what setting are we removing? You mean
> that we reset nChildXids, even if it's already 0? Hard to see how that
> matters."
>
0
s->maxChildXids = 0; // ever set to 0
best regards,
Ranier Vilela
De: Andres Freund
Enviado: quarta-feira, 13 de novembro de 2019 17:10
Para: Ranier Vilela
Cc: PostgreSQL Hackers
Assunto: Re: [PATCH] Improve AtSubCommit_childXids
Hi,
On 2019-11-13 16
Hi,
On 2019-11-13 16:18:46 +, Ranier Vilela wrote:
> Surely that "s->nChildXids > 0", protects s->childXids to be NULL!
> But, when we exchange the test (s->nChildXids > 0) by (s->childXids != NULL),
> I believe we have the same protection, because, if "s->childXids" is not
> NULL, "s->nChil
Hi,
Surely that "s->nChildXids > 0", protects s->childXids to be NULL!
But, when we exchange the test (s->nChildXids > 0) by (s->childXids != NULL), I
believe we have the same protection, because, if "s->childXids" is not NULL,
"s->nChildXids" is > 0, naturally.
That way we can improve the funct
