Re: Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-03-07 Thread David Steele
On 3/5/18 10:09 PM, Yugo Nagata wrote: > On Thu, 1 Mar 2018 14:29:58 -0800 > Andres Freund wrote: > >> Hi, >> >> On 2018-01-11 11:03:26 +0900, Yugo Nagata wrote: >>> However, I don't inisist on this patch, so If anyone other don't need this >>> feature, I'll withdraw this. >> >> Given this is whe

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-03-05 Thread Yugo Nagata
On Thu, 1 Mar 2018 14:29:58 -0800 Andres Freund wrote: > Hi, > > On 2018-01-11 11:03:26 +0900, Yugo Nagata wrote: > > However, I don't inisist on this patch, so If anyone other don't need this > > feature, I'll withdraw this. > > Given this is where the discussion dried up more than a month ago

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-03-01 Thread Andres Freund
Hi, On 2018-01-11 11:03:26 +0900, Yugo Nagata wrote: > However, I don't inisist on this patch, so If anyone other don't need this > feature, I'll withdraw this. Given this is where the discussion dried up more than a month ago I'm inclined to mark this as rejected unless somebody wants to argue o

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-01-10 Thread Yugo Nagata
On Sun, 31 Dec 2017 11:57:02 -0500 Tom Lane wrote: > Yugo Nagata writes: > > Attached is a patch to implement a feature to get the current function > > name by GET DIAGNOSTICS in PL/pgSQL function. > > While this is certainly not a very large patch, it's still code that > we'd have to maintain

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-01-02 Thread Peter Eisentraut
On 12/31/17 11:57, Tom Lane wrote: > 3. In connection with #2, I'm dubious that FUNCTION_NAME is le mot > juste, because that would seem to imply that it is just the name, > which it isn't. If we stick with the regprocedureout semantics > I'd be inclined to propose FUNCTION_SIGNATURE. The SQL sta

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-31 Thread Tom Lane
Yugo Nagata writes: > Attached is a patch to implement a feature to get the current function > name by GET DIAGNOSTICS in PL/pgSQL function. While this is certainly not a very large patch, it's still code that we'd have to maintain forever, so I think it's appropriate to ask some harder questions

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-31 Thread Fabien COELHO
Attached is a patch to implement a feature to get the current function name by GET DIAGNOSTICS in PL/pgSQL function. Shouldn't it be tested somewhere? -- Fabien.

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-31 Thread Yugo Nagata
On Sun, 31 Dec 2017 17:54:06 +0900 (JST) Tatsuo Ishii wrote: > >> Attached is a patch to implement a feature to get the current function > >> name by GET DIAGNOSTICS in PL/pgSQL function. > > > > Could you add it to the nexf CF, I have not seen it there? Maybe the > > deadline is tonight... > >

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-31 Thread Tatsuo Ishii
>> Attached is a patch to implement a feature to get the current function >> name by GET DIAGNOSTICS in PL/pgSQL function. > > Could you add it to the nexf CF, I have not seen it there? Maybe the > deadline is tonight... I have added this to the next CF. Best regards, -- Tatsuo Ishii SRA OSS, In

Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-31 Thread Fabien COELHO
Attached is a patch to implement a feature to get the current function name by GET DIAGNOSTICS in PL/pgSQL function. Could you add it to the nexf CF, I have not seen it there? Maybe the deadline is tonight... -- Fabien.

[PATCH] GET DIAGNOSTICS FUNCTION_NAME

2017-12-28 Thread Yugo Nagata
Hi, Attached is a patch to implement a feature to get the current function name by GET DIAGNOSTICS in PL/pgSQL function. Currentyly, we can get call stack by GET DIAGNOSTICS PG_CONTEXT, but we cannot get the function name directly. One of our clients wanted this feature for debugging, and this wa