Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Euler Taveira
On Sat, 16 May 2020 at 16:31, Tom Lane wrote: > > I think (b) would be a break in the archive format, with unclear > consequences, so I'm not in favor of that. > > I came to the same conclusion while inspecting the source code. -- Euler Taveira http://www.2ndQuadrant.com/ Postg

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Tom Lane
Euler Taveira writes: > I'm wondering why there is such a distinction. We have some options: > (a) leave it as is and document that those 2 options has no effect in > pg_dump > and possibly add a warning to report if someone uses it with an archive > format; > (b) exclude owner and tablespace fro

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Euler Taveira
On Sat, 16 May 2020 at 04:20, Christopher Baines wrote: > > Tom Lane writes: > > > Christopher Baines writes: > >> So I'm new to poking around in the PostgreSQL code, so this is a bit of > >> a shot in the dark. I'm having some problems with pg_dump, and a > >> database with tablespaces. A coup

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Christopher Baines
Tom Lane writes: > Christopher Baines writes: >> So I'm new to poking around in the PostgreSQL code, so this is a bit of >> a shot in the dark. I'm having some problems with pg_dump, and a >> database with tablespaces. A couple of the tables are not in the default >> tablespace, and I want to i

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-15 Thread Tom Lane
Christopher Baines writes: > So I'm new to poking around in the PostgreSQL code, so this is a bit of > a shot in the dark. I'm having some problems with pg_dump, and a > database with tablespaces. A couple of the tables are not in the default > tablespace, and I want to ignore this for the dump.

[PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-15 Thread Christopher Baines
23ca2878 Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Fri, 15 May 2020 20:57:26 +0100 Subject: [PATCH] Fix pg_dump --no-tablespaces for the custom format --- src/bin/pg_dump/pg_dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bi