Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-18 Thread Thomas Munro
On Tue, Sep 18, 2018 at 9:25 PM Oleksii Kliukin wrote: > > On 18. Sep 2018, at 03:18, Thomas Munro > > wrote: > > Here is a patch that I propose to commit and back-patch to 9.4. I > > just wrote a suitable commit message, edited the comments lightly and > > fixed some whitespace. > > Thanks! >

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-18 Thread Oleksii Kliukin
> On 18. Sep 2018, at 03:18, Thomas Munro wrote: > > On Tue, Sep 18, 2018 at 1:15 AM Chris Travers > wrote: >> On Mon, Sep 17, 2018 at 2:59 PM Oleksii Kliukin wrote: >>> With the patch applied, the posix_fallocate loop terminated right away >>> (because >>> of QueryCancelPending flag set t

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-17 Thread Thomas Munro
On Tue, Sep 18, 2018 at 1:15 AM Chris Travers wrote: > On Mon, Sep 17, 2018 at 2:59 PM Oleksii Kliukin wrote: >> With the patch applied, the posix_fallocate loop terminated right away >> (because >> of QueryCancelPending flag set to true) and the backend went through the >> cleanup, showing an E

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-17 Thread Chris Travers
On Mon, Sep 17, 2018 at 2:59 PM Oleksii Kliukin wrote: > > > > On 7. Sep 2018, at 17:57, Chris Travers > wrote: > > > > Hi; > > > > Attached is the patch we are fully testing at Adjust. There are a few > non-obvious aspects of the code around where the patch hits.I have run > make check on

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-17 Thread Chris Travers
First, I have attached a cleaned-up revision (pg_indent, removing a dangling comment etc) On Fri, Sep 14, 2018 at 1:16 PM Thomas Munro wrote: > On Sat, Sep 8, 2018 at 3:57 AM Chris Travers > wrote: > > Attached is the patch we are fully testing at Adjust. > > Thanks! > > > I have run make check

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-17 Thread Oleksii Kliukin
> On 7. Sep 2018, at 17:57, Chris Travers wrote: > > Hi; > > Attached is the patch we are fully testing at Adjust. There are a few > non-obvious aspects of the code around where the patch hits.I have run > make check on Linux and MacOS, and make check-world on Linux (check-world > fai

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-14 Thread Thomas Munro
On Sat, Sep 8, 2018 at 3:57 AM Chris Travers wrote: > Attached is the patch we are fully testing at Adjust. Thanks! > I have run make check on Linux and MacOS, and make check-world on Linux > (check-world fails on MacOS on all versions and all branches due to ecpg > failures). FWIW it's entir

Re: [PATCH] Fix for infinite signal loop in parallel scan

2018-09-07 Thread Andres Freund
Hi, On 2018-09-07 17:57:05 +0200, Chris Travers wrote: > Attached is the patch we are fully testing at Adjust. For the future, please don't start a separate threads from the bugreport / original discussion. Makes it much harder to follow. Greetings, Andres Freund

[PATCH] Fix for infinite signal loop in parallel scan

2018-09-07 Thread Chris Travers
Hi; Attached is the patch we are fully testing at Adjust. There are a few non-obvious aspects of the code around where the patch hits.I have run make check on Linux and MacOS, and make check-world on Linux (check-world fails on MacOS on all versions and all branches due to ecpg failures). Aut